Deprecate passing settings in restore requests #53268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we accept a `settings` field in snapshot restore requests, but this field is not used. This commit deprecates it.
DaveCTurner
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
DaveCTurner
added a commit
that referenced
this pull request
Mar 9, 2020
DaveCTurner
added a commit
that referenced
this pull request
Mar 9, 2020
Today we accept a `settings` field in snapshot restore requests, but this field is not used. This commit deprecates it.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 9, 2020
DaveCTurner
added a commit
that referenced
this pull request
Mar 9, 2020
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 9, 2020
The unused `settings` value was deprecated in elastic#53268 so this commit removes it.
DaveCTurner
added a commit
that referenced
this pull request
Mar 9, 2020
The unused `settings` value was deprecated in #53268 so this commit removes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we accept a
settingsfield in snapshot restore requests, but this fieldis not used. This commit deprecates it.