Skip to content

SQL: use a calendar interval for histograms over 1 month intervals #52586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 24, 2020
Merged

SQL: use a calendar interval for histograms over 1 month intervals #52586

merged 6 commits into from
Feb 24, 2020

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Feb 20, 2020

Addresses #51538.

@astefan astefan requested review from costin, bpintea and matriv February 20, 2020 18:05
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/SQL)

matriv
matriv approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left 2 minor comments.

bpintea
bpintea approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

costin
costin approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Should we add 1 day as well?

@astefan
Copy link
Contributor Author

astefan commented Feb 24, 2020

LGTM.

Should we add 1 day as well?

@costin created #52713 for INTERVAL 1 DAY handling.

@astefan astefan merged commit 928b11a into elastic:master Feb 24, 2020
@astefan astefan deleted the 51538_impl branch February 24, 2020 16:02
astefan added a commit to astefan/elasticsearch that referenced this pull request Feb 24, 2020
@astefan
SQL: use a calendar interval for histograms over 1 month intervals (e…
b4f8d79 
…lastic#52586)

(cherry picked from commit 928b11a)
@astefan astefan mentioned this pull request Feb 24, 2020
Merged
astefan added a commit that referenced this pull request Feb 24, 2020
@astefan
SQL: use a calendar interval for histograms over 1 month intervals (#…
ed6b10b 
…52586) (#52715)

(cherry picked from commit 928b11a)
@codebrain codebrain mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin costin costin approved these changes

@bpintea bpintea bpintea approved these changes

@matriv matriv matriv approved these changes

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement v7.7.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@astefan @elasticmachine @costin @bpintea @matriv @jakelandis