Skip to content

Limit max direct memory size to half of heap size #42006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2019

Conversation

jasontedor
Copy link
Member

This commit adds an ergonomic choice ot the max direct memory size such that if it is not set, we default it to half of the heap size.

Closes #41954
Relates #41962

This commit adds an ergonomic choice ot the max direct memory size such
that if it is not set, we default it to half of the heap size.
@jasontedor jasontedor added >enhancement :Core/Infra/Resiliency Keep running when everything is ok. Die quickly if things go horribly wrong. v8.0.0 v7.2.0 labels May 9, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasontedor jasontedor merged commit 8a06893 into elastic:master May 9, 2019
jasontedor added a commit that referenced this pull request May 9, 2019
This commit adds an ergonomic choice ot the max direct memory size such
that if it is not set, we default it to half of the heap size.
@jasontedor jasontedor deleted the limit-max-direct-memory-size branch May 9, 2019 14:11
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
This commit adds an ergonomic choice ot the max direct memory size such
that if it is not set, we default it to half of the heap size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Resiliency Keep running when everything is ok. Die quickly if things go horribly wrong. >enhancement v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure a limit on direct memory usage
5 participants