Remove initial_master_nodes on node restart #37580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>non-issue
>test
|
Pinging @elastic/es-distributed |
|
@elasticmachine retest this please |
|
@elasticmachine run the gradle build tests 1 |
DaveCTurner
reviewed
Jan 18, 2019
| @@ -935,7 +935,10 @@ Settings closeForRestart(RestartCallback callback, int minMasterNodes) throws Ex | |||
| } | |||
| if (minMasterNodes >= 0) { | |||
| assert DISCOVERY_ZEN_MINIMUM_MASTER_NODES_SETTING.exists(newSettings.build()) == false : "min master nodes is auto managed"; | |||
| newSettings.put(DISCOVERY_ZEN_MINIMUM_MASTER_NODES_SETTING.getKey(), minMasterNodes).build(); | |||
| newSettings.put(DISCOVERY_ZEN_MINIMUM_MASTER_NODES_SETTING.getKey(), minMasterNodes); | |||
| if (callbackSettings != null && INITIAL_MASTER_NODES_SETTING.exists(callbackSettings) == false) { | |||
There was a problem hiding this comment.
I think returning null from onNodeStopped is a bug since it looks equivalent to returning Settings.EMPTY. The only place I can see this happening is QuorumGatewayIT in which the onNodeStopped override can be completely removed. Can we just do that and then assert it's not null?
|
@elasticmachine run the gradle build tests 1 |
|
@elasticmachine run the gradle build tests 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests (DedicatedClusterSnapshotRestoreIT.testRestoreIndexWithShardsMissingInLocalGateway) were split-braining since being switched to Zen2 because the bootstrap setting was left around when nodes got restarted with data folders wiped.
The test in question here was starting one node (which autobootstrapped to that single node), then another node. The first node was then shut down (after excluding it from the voting configuration), its data folder wiped, and restarted. After restart, the node had an empty data folder yet initial_master_nodes set to itself (i.e. same name). This made the node sometimes form a cluster of its own, and not rejoin the existing cluster with the other node.
See e.g. https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+g1gc/278/console