Core: Don't rely on java time for epoch seconds formatting #34086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be compatible with joda time, this adds an epoch seconds formatter, that is able to parse floating point values. However joda time discards the floating point values, but still parses the data, where as this one is able to parse the whole value including milliseconds. This also allows to name the formatter 'epoch_seconds' with an s at the end just like 'epoch_millis'.
spinscale
added
>non-issue
review
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
rjernst
approved these changes
Sep 26, 2018
| @@ -1374,7 +1373,7 @@ public static DateFormatter forPattern(String input, Locale locale) { | |||
| return YEAR_MONTH; | |||
| } else if ("yearMonthDay".equals(input) || "year_month_day".equals(input)) { | |||
| return YEAR_MONTH_DAY; | |||
| } else if ("epoch_second".equals(input)) { | |||
| } else if ("epoch_second".equals(input) || "epoch_seconds".equals(input)) { | |||
There was a problem hiding this comment.
If we are going to add the plural (+1), then we should add a deprecation warning for the non-plural.
There was a problem hiding this comment.
ok, this requires some more changes in other tests, I will add this in a follow up PR, but do not want to clutter within this PR, just sticking with epoch_second for now
server/src/main/java/org/elasticsearch/common/time/DateFormatters.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/common/time/EpochSecondsDateFormatter.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public DateFormatter withZone(ZoneId zoneId) { | ||
| return this; |
There was a problem hiding this comment.
This seems trappy...we should at least have a comment why this is ok, but it seems like we could drop timezones?
There was a problem hiding this comment.
the java-time branch will create new objects with a timezone for all the date formatters (same needs to be done for the locale). I will create a separate PR for that after this one.
server/src/test/java/org/elasticsearch/common/time/DateFormattersTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/common/time/DateFormattersTests.java
Outdated
Show resolved
Hide resolved
…R to not clutter it, requires more test fixes
spinscale
added a commit
that referenced
this pull request
Sep 28, 2018
In order to be compatible with joda time, this adds an epoch seconds formatter, that is able to parse floating point values. However joda time discards the floating point values, but still parses the data, where as this one is able to parse the whole value including milliseconds.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 28, 2018
* master: Use more precise does S3 bucket exist method (elastic#34123) LLREST: Introduce a strict mode (elastic#33708) [CCR] Adjust list retryable errors (elastic#33985) Fix AggregationFactories.Builder equality and hash regarding order (elastic#34005) MINOR: Remove some deadcode in NodeEnv and Related (elastic#34133) Rest-Api-Spec: Correct spelling in filter_path description (elastic#33154) Core: Don't rely on java time for epoch seconds formatting (elastic#34086) Retry errors when fetching follower global checkpoint. (elastic#34019) Watcher: Reenable watcher stats REST tests (elastic#34107) Remove special-casing of Synonym filters in AnalysisRegistry (elastic#34034) Rename CCR APIs (elastic#34027) Fixed CCR stats api serialization issues and (elastic#33983) Support 'string'-style queries on metadata fields when reasonable. (elastic#34089) Logging: Drop Settings from security logger get calls (elastic#33940) SQL: Internal refactoring of operators as functions (elastic#34097)
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
In order to be compatible with joda time, this adds an epoch seconds formatter, that is able to parse floating point values. However joda time discards the floating point values, but still parses the data, where as this one is able to parse the whole value including milliseconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be compatible with joda time, this adds an epoch seconds
formatter, that is able to parse floating point values.
However joda time discards the floating point values, but still parses
the data, where as this one is able to parse the whole value including
milliseconds.
This also allows to name the formatter 'epoch_seconds' with an s at the
end just like 'epoch_millis'.