Logging: Drop Settings from security logger get calls #33940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Settings` is no longer required to get a `Logger` and we went to quite a bit of effort to pass it to the `Logger` getters. This removes the `Settings` from all of the logger fetches in security and x-pack:core.
nik9000
added
review
:Core/Infra/Logging
|
Pinging @elastic/es-core-infra |
|
This must have fallen into some CI downtime, so no jenkins run was triggered yet, so: |
cbuescher
approved these changes
Sep 26, 2018
| public ChainTransformFactory(Settings settings, TransformRegistry registry) { | ||
| super(Loggers.getLogger(ExecutableChainTransform.class, settings)); | ||
| public ChainTransformFactory(TransformRegistry registry) { | ||
| super(Loggers.getLogger(ExecutableChainTransform.class)); |
There was a problem hiding this comment.
Out of curiosity: in other instances you replaced Loggers.getLogger with LogManager.getLogger. Any advantaged of the later? If so, could this also be done here or doesn't it matter?
There was a problem hiding this comment.
I should have done it here, yeah. The advantage of the latter is that the former is deprecated. It mostly just delegates to the latter.
|
@elasticmachine retest this please |
nik9000
added a commit
that referenced
this pull request
Sep 28, 2018
`Settings` is no longer required to get a `Logger` and we went to quite a bit of effort to pass it to the `Logger` getters. This removes the `Settings` from all of the logger fetches in security and x-pack:core.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 28, 2018
* master: Use more precise does S3 bucket exist method (elastic#34123) LLREST: Introduce a strict mode (elastic#33708) [CCR] Adjust list retryable errors (elastic#33985) Fix AggregationFactories.Builder equality and hash regarding order (elastic#34005) MINOR: Remove some deadcode in NodeEnv and Related (elastic#34133) Rest-Api-Spec: Correct spelling in filter_path description (elastic#33154) Core: Don't rely on java time for epoch seconds formatting (elastic#34086) Retry errors when fetching follower global checkpoint. (elastic#34019) Watcher: Reenable watcher stats REST tests (elastic#34107) Remove special-casing of Synonym filters in AnalysisRegistry (elastic#34034) Rename CCR APIs (elastic#34027) Fixed CCR stats api serialization issues and (elastic#33983) Support 'string'-style queries on metadata fields when reasonable. (elastic#34089) Logging: Drop Settings from security logger get calls (elastic#33940) SQL: Internal refactoring of operators as functions (elastic#34097)
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
`Settings` is no longer required to get a `Logger` and we went to quite a bit of effort to pass it to the `Logger` getters. This removes the `Settings` from all of the logger fetches in security and x-pack:core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settingsis no longer required to get aLoggerand we went to quitea bit of effort to pass it to the
Loggergetters. This removes theSettingslogger lookups from the security and x-pack:core.