add qa project for running ILM tests against security #32218
Conversation
talevy
added
>test
|
Pinging @elastic/es-core-infra |
This is a bare-bones skeleton for running existing yaml tests with security enabled. Additional tests which test users and roles should follow
talevy
force-pushed
the
ilm-tests-with-security
branch
from
8301607 to
728cbb1
Compare
| // bring in machine learning rest test suite | ||
| task copyILMRestTests(type: Copy) { | ||
| into project.sourceSets.test.output.resourcesDir | ||
| from project(xpackProject('plugin').path).sourceSets.test.resources.srcDirs |
There was a problem hiding this comment.
I realize we use this elsewhere, but was wondering if there's really a reason for it ? xpackProject('plugin') already returns a Project why wrap it in another call ? The additional project(.path) seems unnecessary.
There was a problem hiding this comment.
you're right. I'll try that
| File tmpFile = new File(node.cwd, 'wait.success') | ||
| ant.get(src: "http://${node.httpUri()}/_cluster/health?wait_for_nodes=>=${numNodes}&wait_for_status=yellow", | ||
| dest: tmpFile.toString(), | ||
| username: 'test_user', |
There was a problem hiding this comment.
Would try to get this from the system properties as well.
Maybe extract these into variables to remove repetition.
I'm assuming the properties are there so they can be used with external clusters for which the wait conditions are not called, but that's an implementation detail and looks odd not to consider the properties in here.
|
thanks for the review @colings86 and @atorok. Your suggestions were helpful. I am too quick to turn a blind eye when it comes to gradle/groovy configuration |
This is a bare-bones skeleton for running existing yaml tests with security enabled. Additional tests which test users and roles should follow
add QA project for running ILM tests against security
This is a bare-bones skeleton for running existing yaml tests with security enabled. Additional tests which test users and roles should follow