Add REST tests for avg/min/max/sum metric aggs #26225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
approved these changes
Aug 15, 2017
| type : double | ||
| string_field: | ||
| type: keyword | ||
| - do: |
There was a problem hiding this comment.
I think we get this for free as part of creating the index now.
| wait_for_status: green | ||
|
|
||
| - do: | ||
| index: |
There was a problem hiding this comment.
I'd do these as a _bulk instead just as a matter of habit. It'll be marginally faster and shorter to read.
|
Thanks @nik9000 :) |
69 tasks
polyfractal
added a commit
that referenced
this pull request
Aug 16, 2017
Adds some REST tests for avg/min/max/sum metric aggregations Related to #26220
polyfractal
added a commit
that referenced
this pull request
Aug 16, 2017
Adds some REST tests for avg/min/max/sum metric aggregations Related to #26220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some REST tests for avg/min/max/sum metric aggregations.
Related to #26220