Add precise logging on unknown or invalid settings #20951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
>enhancement
review
:Core/Infra/Settings
nik9000
approved these changes
Oct 15, 2016
Today when logging an unknown or invalid setting, the log message does not contain the source. This means that if we are archiving such a setting, we do not specify where the setting is from (an index, and which index, or a persistent or transient cluster setting). This commit provides such logging for the end user can better understand the consequences of the unknown or invalid setting.
jasontedor
added a commit
that referenced
this pull request
Oct 15, 2016
Today when logging an unknown or invalid setting, the log message does not contain the source. This means that if we are archiving such a setting, we do not specify where the setting is from (an index, and which index, or a persistent or transient cluster setting). This commit provides such logging for the end user can better understand the consequences of the unknown or invalid setting. Relates #20951
jasontedor
added a commit
that referenced
this pull request
Oct 15, 2016
Today when logging an unknown or invalid setting, the log message does not contain the source. This means that if we are archiving such a setting, we do not specify where the setting is from (an index, and which index, or a persistent or transient cluster setting). This commit provides such logging for the end user can better understand the consequences of the unknown or invalid setting. Relates #20951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when logging an unknown or invalid setting, the log message does
not contain the source. This means that if we are archiving such a
setting, we do not specify where the setting is from (an index, and
which index, or a persistent or transient cluster setting). This commit
provides such logging for the end user can better understand the
consequences of the unknown or invalid setting.
Closes #20946