Fix error trace stack trace assertions #137124
Open
+32
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchaplin
added
>test
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
benchaplin
commented
Oct 24, 2025
| throw new UncheckedIOException(e); | ||
| } finally { | ||
| // Always forward to the original channel | ||
| channel.sendResponse(response); |
There was a problem hiding this comment.
Moving these into the finally block so that AssertionErrors don't stop execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of a facepalm moment here: I wrote these tests and they aren't doing ANYTHING.
The ErrorTraceHelper methods work by adding request handling behavior that deconstructs a batched query response (NodeQueryResponse) and checks whether exceptions have stack traces or not. This behavior must be in place before the search request is made. I had put them after, meaning the assertions were never executed.
This PR makes that change: adding the handling before the search request is made. I changed the method names from "assert" -> "expect" to better describe this proper usage.