ESQL: Log profile on test error #131474
Draft
ESQL: Log profile on test error #131474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivancea
added
>test
nik9000
reviewed
Jul 17, 2025
| EsqlResponse response = runEsqlSyncNoWarningsChecks(requestObject); | ||
| assertWarnings(response.response, assertWarnings); | ||
| return response.json; | ||
| } |
There was a problem hiding this comment.
What if you put the ProfileLogger as another argument here? It can be nullable for PR or two, but I think in all the callers we want to log on failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the ESQL request profile when an error fail. To be implemented on: