[TEST] inject a random index to TestClusterService in BaseQueryTestCase#init

[javanna]

Some of our next queries to refactor rely on some state taken from the cluster state. That is why we need to mock cluster service and inject an index to it, the index that we simulate the execution of the queries against. The best would be to have multiple indices actually, but that would make our setup a lot more complicated, especially given that IndexQueryParseService is still per index. We might be able to improve that in the future though, for now this is as good as it gets.

[alexksikes]

This looks good. I would also add a method to get the name of the index so we can use it in say Indices Query.

[javanna]

I would also add a method to get the name of the index so we can use it in say Indices Query.

Makes sense, I had forgotten about that, I pushed an update.

[cbuescher]

Just an idea, should the index maybe have the same version as the one we are randomly picking in the settings? Maybe not, I think I introduced it there to test both strict and non-strict mapping checks, but maybe we don't need that here.

[javanna]

sure we can do that, I didn't remember we were picking a version randomly to be honest, will look into that ;)

[cbuescher]

Also did a quick look, only one suggestion, otherwise LGTM

[javanna]

@cbuescher I pushed a new commit, hopefully sorted out index settings now. please have a look.

[cbuescher]

LGTM

[alexksikes]

LGTM