Skip to content

Skip rerank tests in mixed clusters #126415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Apr 7, 2025

If the clusters don't support inference test services, skip tests that require inference services. Hence, we should check for rerank tests.

Relates #123074

@dnhatn dnhatn added :Analytics/ES|QL AKA ESQL >test Issues or PRs that are addressing/adding tests labels Apr 7, 2025
@dnhatn dnhatn marked this pull request as ready for review April 7, 2025 15:37
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@dnhatn dnhatn requested a review from craigtaverner April 7, 2025 15:38
@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Apr 7, 2025
@dnhatn dnhatn requested a review from afoucret April 7, 2025 15:52
@dnhatn
Copy link
Member Author

dnhatn commented Apr 7, 2025

Thanks @idegtiarenko.

@dnhatn dnhatn merged commit 894d92a into elastic:main Apr 7, 2025
18 checks passed
@dnhatn dnhatn deleted the skip-rerank-mixed-cluster branch April 7, 2025 16:43
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Jun 4, 2025
If the clusters don't support inference test services, skip tests that require inference services.
Hence, we should check for rerank tests.

Relates elastic#123074
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Jun 5, 2025
If the clusters don't support inference test services, skip tests that require inference services. 
Hence, we should check for rerank tests.

Relates elastic#123074
@dnhatn dnhatn added the v8.19.0 label Jun 5, 2025
dnhatn added a commit that referenced this pull request Jun 5, 2025
Backport of #126415 to 8.19

If the clusters don't support inference test services, skip tests that 
require inference services. Hence, we should check for rerank tests.

Relates #123074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL serverless-linked Added by automation, don't add manually Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants