Refactors FunctionScoreQueryBuilder and Parser #12608
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@javanna Feel free to take a look. Thank you. |
alexksikes
force-pushed
the
feature/query-refactoring-function-score-query
branch
from
efef5b7 to
4b4cd70
Compare
Member
There was a problem hiding this comment.
shouldn't we be using Writeable instead?
Relates to elastic#10217 This PR is against the query-refactoring branch. Closes elastic#12608
alexksikes
force-pushed
the
feature/query-refactoring-function-score-query
branch
from
4b4cd70 to
f42a1bb
Compare
Contributor
Author
|
@javanna I rebased it if you want to take a look. Thank you. |
There was a problem hiding this comment.
Why not wrap the caught exception instead of swallowing the actual cause of the failure?
Member
|
superseded by #13653. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #10217
This PR is against the query-refactoring branch.