Skip to content

Run TransportGetIndexAction on local node #125652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025

Conversation

nielsbauman
Copy link
Contributor

This action solely needs the cluster state, it can run on any node. Since this is the last class/action that extends the ClusterInfo abstract classes, we remove those classes too as they're not required anymore.

Relates #101805

This action solely needs the cluster state, it can run on any node.
Since this is the last class/action that extends the `ClusterInfo`
abstract classes, we remove those classes too as they're not required
anymore.

Relates elastic#101805
@nielsbauman nielsbauman added >enhancement :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team v9.1.0 labels Mar 26, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @nielsbauman, I've created a changelog YAML for you.

Comment on lines +73 to 78
/**
* The only usage of this constructor is for BwC cross-cluster transforms for clusters before v8.2. The ML team is aware that we
* don't need to support that anymore now that we're on v9. Once they remove that BwC code, we can remove this constructor as well.
*/
@UpdateForV10(owner = UpdateForV10.Owner.DATA_MANAGEMENT)
GetIndexResponse(StreamInput in) throws IOException {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reached out to the ML team and they confirmed that the code that uses the GET index action is for BwC to a version that is no longer supported (v8.2) for cross-cluster transforms. This last usage is:

public static final RemoteClusterActionType<GetIndexResponse> REMOTE_TYPE = new RemoteClusterActionType<>(NAME, GetIndexResponse::new);

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielsbauman nielsbauman enabled auto-merge (squash) April 2, 2025 16:36
@nielsbauman nielsbauman merged commit 483f979 into elastic:main Apr 2, 2025
17 checks passed
@nielsbauman nielsbauman deleted the local-get-index branch April 2, 2025 17:41
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Apr 8, 2025
elasticsearchmachine pushed a commit that referenced this pull request Apr 9, 2025
andreidan pushed a commit to andreidan/elasticsearch that referenced this pull request Apr 9, 2025
This action solely needs the cluster state, it can run on any node.
Since this is the last class/action that extends the `ClusterInfo`
abstract classes, we remove those classes too as they're not required
anymore.

Relates elastic#101805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >enhancement Team:Data Management Meta label for data/management team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants