-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Run TransportGetIndexAction
on local node
#125652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This action solely needs the cluster state, it can run on any node. Since this is the last class/action that extends the `ClusterInfo` abstract classes, we remove those classes too as they're not required anymore. Relates elastic#101805
Pinging @elastic/es-data-management (Team:Data Management) |
Hi @nielsbauman, I've created a changelog YAML for you. |
/** | ||
* The only usage of this constructor is for BwC cross-cluster transforms for clusters before v8.2. The ML team is aware that we | ||
* don't need to support that anymore now that we're on v9. Once they remove that BwC code, we can remove this constructor as well. | ||
*/ | ||
@UpdateForV10(owner = UpdateForV10.Owner.DATA_MANAGEMENT) | ||
GetIndexResponse(StreamInput in) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reached out to the ML team and they confirmed that the code that uses the GET index action is for BwC to a version that is no longer supported (v8.2) for cross-cluster transforms. This last usage is:
elasticsearch/server/src/main/java/org/elasticsearch/action/admin/indices/get/GetIndexAction.java
Line 19 in b15a4a1
public static final RemoteClusterActionType<GetIndexResponse> REMOTE_TYPE = new RemoteClusterActionType<>(NAME, GetIndexResponse::new); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Relates: elastic#125652 Resolves: elastic#126204
This action solely needs the cluster state, it can run on any node. Since this is the last class/action that extends the `ClusterInfo` abstract classes, we remove those classes too as they're not required anymore. Relates elastic#101805
This action solely needs the cluster state, it can run on any node. Since this is the last class/action that extends the
ClusterInfo
abstract classes, we remove those classes too as they're not required anymore.Relates #101805