Remove @UpdateForV9 annotation from ReindexRequest#failOnSizeSpecified
#122729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fied` We do need this check to make sure we don't silently accept requests with ignored `size` parameter specified since `max_docs` is optional. We want to notify users that they must use `max_docs` and specifying `size` is a mistake. This behaviour is tested in the `reindex/20_validation/specifying size fails` test.
arteam
added
>non-issue
:Distributed Indexing/Reindex
elasticsearchmachine
added
Team:Distributed Indexing
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
arteam
added
backport
auto-backport
arteam
requested review from
Tim-Brooks,
henningandersen and
DaveCTurner
and removed request for
henningandersen
DaveCTurner
requested changes
Feb 17, 2025
There was a problem hiding this comment.
This doesn't actually address the task tho. We haven't supported size for all of 8.x, see #43373. I don't think we need to treat this parameter specially any more, we can just reject it as if it were any other unknown parameter.
arteam
force-pushed
the
remove-updatev9-reindex-request
branch
from
3da329b to
495b0fd
Compare
arteam
force-pushed
the
remove-updatev9-reindex-request
branch
from
495b0fd to
9914525
Compare
DaveCTurner
reviewed
Feb 17, 2025
| body: { "text": "test" } | ||
|
|
||
| - do: | ||
| catch: /invalid parameter \[size\], use \[max_docs\] instead/ |
There was a problem hiding this comment.
Could we instead keep the test but generalize this regex to handle both the old specialized message and the new general one?
There was a problem hiding this comment.
Thanks, I've updated it!
arteam
removed
auto-backport
arteam
added
auto-backport
arteam
commented
Feb 17, 2025
| @@ -167,3 +167,7 @@ if (OS.current() == OS.WINDOWS) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| tasks.named("yamlRestCompatTestTransform").configure { task -> | |||
| task.skipTest("reindex/20_validation/specifying size fails", "size is rejected in 9.0") | |||
There was a problem hiding this comment.
Can't check the compatibility mode for the parameter rejected by the parser, so the compatibility test
./gradlew ":modules:reindex:yamlRestCompatTest" --tests "org.elasticsearch.index.reindex.ReindexClientYamlTestSuiteIT.test {yaml=reindex/20_validation/specifying size fails}"
fails if we don't mute it.
|
LGTM still |
DaveCTurner
approved these changes
Feb 17, 2025
💚 Backport successful
|
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Feb 17, 2025
…fied` (elastic#122729) The size parameter hasn't been accepted since 8.0, end users should use max_docs and if the user specify it, we can defer to the standard error message produced by the parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do need this check to make sure we don't silently accept requests with ignoredsizeparameter specified sincemax_docsis optional. We want to notify users that they must usemax_docsand specifyingsizeis a mistake.This behaviour is tested in thereindex/20_validation/specifying size failstest.The
sizeparameter hasn't been accepted since 8.0, end users should usemax_docsand if the user specify it, we can defer to the standard error message produced by the parser.