Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation of custom auth engine example #121089

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix compilation of custom auth engine example #121089

wants to merge 7 commits into from
+19 −12

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Jan 28, 2025

No description provided.

@rjernst rjernst added >non-issue :Security/Security Security issues without another label auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 labels Jan 28, 2025
@rjernst rjernst requested a review from gmarouli January 28, 2025 18:44
@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Jan 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@rjernst rjernst mentioned this pull request Jan 28, 2025
Open
@rjernst rjernst requested a review from a team January 28, 2025 18:48
gmarouli
gmarouli approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@gmarouli gmarouli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing this! I was not aware of it.

@rjernst
Copy link
Member Author

rjernst commented Jan 30, 2025

@elasticmachine update branch

@rjernst
Copy link
Member Author

rjernst commented Jan 30, 2025

@elasticmachine update branch

@rjernst rjernst enabled auto-merge (squash) January 31, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarouli gmarouli gmarouli approved these changes

@breskeby breskeby breskeby approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged >non-issue :Security/Security Security issues without another label Team:Security Meta label for security team v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rjernst @elasticsearchmachine @breskeby @gmarouli @elasticmachine