Add classifier to version specific jar artifacts #121083
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mrjar plugin produces artifacts for each java version that may be consumed downstream. This commit fixes an issue with gradle dependencies when multiple java versions are depended on.
rjernst
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
approved these changes
Jan 28, 2025
prdoyle
reviewed
Jan 28, 2025
| @@ -163,6 +163,7 @@ private void addJar(Project project, SourceSet sourceSet, int javaVersion) { | |||
| project.getConfigurations().register("java" + javaVersion); | |||
| TaskProvider<Jar> jarTask = project.getTasks().register("java" + javaVersion + "Jar", Jar.class, task -> { | |||
| task.from(sourceSet.getOutput()); | |||
| task.getArchiveClassifier().set("java" + javaVersion); | |||
There was a problem hiding this comment.
I don't know enough about how this works... will this select the newest applicable one, and default to java if there are none?
There was a problem hiding this comment.
No, this is about the output artifact name. Previously these different tasks for eg java 21 and 23 would create the same jar name. By adding a classifier, each is unique and won't overwrite each other.
|
The example plugin failure is unrelated, I opened #121089 to fix. |
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mrjar plugin produces artifacts for each java version that may be consumed downstream. This commit fixes an issue with gradle dependencies when multiple java versions are depended on.