-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Add missing traces ilm policy for OTel traces data streams #119449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-data-management (Team:Data Management) |
Hi @felixbarny, I've created a changelog YAML for you. |
lahsivjar
reviewed
Jan 2, 2025
x-pack/plugin/core/template-resources/src/main/resources/traces@settings.json
Show resolved
Hide resolved
lahsivjar
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
gregkalapos
reviewed
Jan 3, 2025
x-pack/plugin/core/template-resources/src/main/resources/traces@settings.json
Show resolved
Hide resolved
gregkalapos
approved these changes
Jan 7, 2025
This was referenced Jan 9, 2025
felixbarny
added a commit
to felixbarny/elasticsearch
that referenced
this pull request
Jan 9, 2025
felixbarny
added a commit
to felixbarny/elasticsearch
that referenced
this pull request
Jan 9, 2025
felixbarny
added a commit
to felixbarny/elasticsearch
that referenced
this pull request
Jan 9, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 9, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 9, 2025
felixbarny
added a commit
that referenced
this pull request
Jan 9, 2025
sarog
pushed a commit
to sarog/elasticsearch
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
>bug
:Data Management/Data streams
Data streams and their lifecycles
external-contributor
Pull request authored by a developer outside the Elasticsearch team
serverless-linked
Added by automation, don't add manually
Team:Data Management
Meta label for data/management team
v8.16.3
v8.17.1
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a default ILM policy for traces. This is important for OTel data streams especially, because these don't roll over by default at all when no ILM policy has been defined.
This ILM policy doesn't have a default retention, in line with the default logs and metrics ILM policies used by integrations and OTel data streams. APM data streams are not affected by this, as they don't import traces@settings and define their own default ILM policies (which have a default retention of 10d).