Fix score count validation in reranker response #111424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
needs:triage
demjened
added
:Search Relevance/Ranking
elasticsearchmachine
added
Team:Search Relevance
|
Hi @demjened, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
…m:demjened/elasticsearch into demjened/fix-rerank-score-validation-8-15
demjened
commented
Jul 29, 2024
| request.getInferenceEntityId(), | ||
| request.getTaskType(), | ||
| CohereService.NAME, | ||
| new CohereRerankServiceSettings(new CohereServiceSettings()), |
There was a problem hiding this comment.
I had to modify this line because this constructor doesn't exist on 8.15. There's no difference in the behavior of the test plugin.
benwtrent
approved these changes
Jul 29, 2024
pmpailis
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #111212 into 8.15.