Checking both node and cluster settings in NodeDeprecationChecks (#82487)

This commit changes NodeDeprecationChecks to look in both node settings and cluster settings when looking
for deprecated or removed settings. This allows it to find settings that were set dynamically.
Closes #82484

Author: masseyke

x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/ClusterDeprecationChecks.java

@@ -659,6 +659,7 @@ static DeprecationIssue checkTemplatesWithCustomAndMultipleTypes(ClusterState st
     static DeprecationIssue checkClusterRoutingAllocationIncludeRelocationsSetting(final ClusterState clusterState) {
         return checkRemovedSetting(
             clusterState.metadata().settings(),
+            null,
             CLUSTER_ROUTING_ALLOCATION_INCLUDE_RELOCATIONS_SETTING,
             "https://ela.st/es-deprecation-7-cluster-routing-allocation-disk-include-relocations-setting",
             "Relocating shards are always taken into account in 8.0.",

x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/DeprecationChecks.java

@@ -101,29 +101,33 @@ private static Set<Setting<Boolean>> getAllDeprecatedNodeRolesSettings() {
                 NodeDeprecationChecks::checkImplicitlyDisabledBasicRealms,
                 NodeDeprecationChecks::checkReservedPrefixedRealmNames,
                 (settings, pluginsAndModules, clusterState, licenseState) -> NodeDeprecationChecks.checkThreadPoolListenerQueueSize(
-                    settings
+                    settings,
+                    clusterState
+                ),
+                (settings, pluginsAndModules, clusterState, licenseState) -> NodeDeprecationChecks.checkThreadPoolListenerSize(
+                    settings,
+                    clusterState
                 ),
-                (settings, pluginsAndModules, clusterState, licenseState) -> NodeDeprecationChecks.checkThreadPoolListenerSize(settings),
                 NodeDeprecationChecks::checkClusterRemoteConnectSetting,
                 NodeDeprecationChecks::checkNodeLocalStorageSetting,
                 (settings, pluginsAndModules, clusterState, licenseState) -> NodeDeprecationChecks
-                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.ENRICH_ENABLED_SETTING),
+                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.ENRICH_ENABLED_SETTING, clusterState),
                 (settings, pluginsAndModules, clusterState, licenseState) -> NodeDeprecationChecks
-                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.FLATTENED_ENABLED),
+                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.FLATTENED_ENABLED, clusterState),
                 (settings, pluginsAndModules, clusterState, licenseState) -> NodeDeprecationChecks
-                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.INDEX_LIFECYCLE_ENABLED),
+                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.INDEX_LIFECYCLE_ENABLED, clusterState),
                 (settings, pluginsAndModules, clusterState, licenseState) -> NodeDeprecationChecks
-                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.MONITORING_ENABLED),
+                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.MONITORING_ENABLED, clusterState),
                 (settings, pluginsAndModules, clusterState, licenseState) -> NodeDeprecationChecks
-                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.ROLLUP_ENABLED),
+                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.ROLLUP_ENABLED, clusterState),
                 (settings, pluginsAndModules, clusterState, licenseState) -> NodeDeprecationChecks
-                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.SNAPSHOT_LIFECYCLE_ENABLED),
+                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.SNAPSHOT_LIFECYCLE_ENABLED, clusterState),
                 (settings, pluginsAndModules, clusterState, licenseState) -> NodeDeprecationChecks
-                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.SQL_ENABLED),
+                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.SQL_ENABLED, clusterState),
                 (settings, pluginsAndModules, clusterState, licenseState) -> NodeDeprecationChecks
-                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.TRANSFORM_ENABLED),
+                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.TRANSFORM_ENABLED, clusterState),
                 (settings, pluginsAndModules, clusterState, licenseState) -> NodeDeprecationChecks
-                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.VECTORS_ENABLED),
+                    .checkNodeBasicLicenseFeatureEnabledSetting(settings, XPackSettings.VECTORS_ENABLED, clusterState),
                 NodeDeprecationChecks::checkMultipleDataPaths,
                 NodeDeprecationChecks::checkDataPathsList,
                 NodeDeprecationChecks::checkBootstrapSystemCallFilterSetting,