Skip to content

Commit a4da5bb

Browse files
committed
Minor changes to mappings setup, using constant for fieldname that is of date type
1 parent 030cb34 commit a4da5bb

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/test/java/org/elasticsearch/index/query/BaseQueryTestCase.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
import org.apache.lucene.search.Query;
2525
import org.elasticsearch.Version;
26+
import org.elasticsearch.action.admin.indices.mapping.put.PutMappingRequest;
2627
import org.elasticsearch.cluster.ClusterService;
2728
import org.elasticsearch.cluster.metadata.IndexMetaData;
2829
import org.elasticsearch.common.compress.CompressedString;
@@ -62,13 +63,12 @@
6263

6364
import java.io.IOException;
6465

65-
import static org.elasticsearch.common.io.Streams.copyToStringFromClasspath;
66-
6766
import static org.hamcrest.Matchers.*;
6867

6968
@Ignore
7069
public abstract class BaseQueryTestCase<QB extends QueryBuilder & Streamable> extends ElasticsearchTestCase {
7170

71+
protected static final String DATE_FIELD_NAME = "age";
7272
private static Injector injector;
7373
private static IndexQueryParserService queryParserService;
7474
private static Index index;
@@ -110,8 +110,8 @@ protected void configure() {
110110
).createInjector();
111111
queryParserService = injector.getInstance(IndexQueryParserService.class);
112112
MapperService mapperService = queryParserService.mapperService;
113-
String mapping = copyToStringFromClasspath("/org/elasticsearch/index/query/mapping.json");
114-
mapperService.merge("person", new CompressedString(mapping), true);
113+
CompressedString mapping = new CompressedString(PutMappingRequest.buildFromSimplifiedDef("type", DATE_FIELD_NAME, "type=date").string());
114+
mapperService.merge("type", mapping, true);
115115
}
116116

117117
@AfterClass

src/test/java/org/elasticsearch/index/query/RangeQueryBuilderTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ protected RangeQueryBuilder createTestQueryBuilder() {
5757
query.to(randomDouble());
5858
}
5959
} else {
60-
query = new RangeQueryBuilder("born");
60+
query = new RangeQueryBuilder(DATE_FIELD_NAME);
6161
query.from(new DateTime(System.currentTimeMillis() - randomIntBetween(0, 1000000)).toString());
6262
query.to(new DateTime(System.currentTimeMillis() + randomIntBetween(0, 1000000)).toString());
6363
if (randomBoolean()) {
@@ -87,7 +87,7 @@ protected RangeQueryBuilder createTestQueryBuilder() {
8787
@Override
8888
protected void assertLuceneQuery(RangeQueryBuilder queryBuilder, Query query, QueryParseContext context) throws IOException {
8989
assertThat(query.getBoost(), is(queryBuilder.boost()));
90-
if (!queryBuilder.fieldname().equals("born")) {
90+
if (!queryBuilder.fieldname().equals(DATE_FIELD_NAME)) {
9191
assertThat(query, instanceOf(TermRangeQuery.class));
9292
TermRangeQuery termRangeQuery = (TermRangeQuery) query;
9393
assertThat(termRangeQuery.includesLower(), is(queryBuilder.includeLower()));
@@ -102,7 +102,7 @@ protected void assertLuceneQuery(RangeQueryBuilder queryBuilder, Query query, Qu
102102
String expectedLowerBracket = queryBuilder.includeLower() ? "[" : "{";
103103
String expectedUpperBracket = queryBuilder.includeUpper() ? "]" : "}";
104104
String queryString = query.rewrite(null).toString();
105-
assertThat(queryString, is("born:"+expectedLowerBracket+expectedFromDate+" TO "+expectedToDate+expectedUpperBracket));
105+
assertThat(queryString, is(DATE_FIELD_NAME+":"+expectedLowerBracket+expectedFromDate+" TO "+expectedToDate+expectedUpperBracket));
106106
}
107107
if (queryBuilder.queryName() != null) {
108108
Query namedQuery = context.copyNamedFilters().get(queryBuilder.queryName());

0 commit comments

Comments
 (0)