Add exclusions for unconsumed response parameters

Author: JeremyDahlgren

server/src/main/java/org/elasticsearch/rest/BaseRestHandler.java

@@ -154,6 +154,10 @@ private boolean assertConsumesSupportedParams(@Nullable Set<String> supported, R
             supportedAndCommon.removeAll(RestRequest.INTERNAL_MARKER_REQUEST_PARAMETERS);
             final var consumed = new TreeSet<>(request.consumedParams());
             consumed.removeAll(RestRequest.INTERNAL_MARKER_REQUEST_PARAMETERS);
+            // Add exclusions for response parameters since they may not always be consumed for every request.
+            final var unconsumedResponseParams = new HashSet<>(responseParams(request.getRestApiVersion()));
+            unconsumedResponseParams.removeAll(consumed);
+            supportedAndCommon.removeAll(unconsumedResponseParams);
             assert supportedAndCommon.equals(consumed)
                 : getName() + ": consumed params " + consumed + " while supporting " + supportedAndCommon;
         }

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestGetSnapshotsAction.java

@@ -14,7 +14,6 @@
 import org.elasticsearch.client.internal.node.NodeClient;
 import org.elasticsearch.common.Strings;
 import org.elasticsearch.common.util.set.Sets;
-import org.elasticsearch.core.Assertions;
 import org.elasticsearch.features.NodeFeature;
 import org.elasticsearch.rest.BaseRestHandler;
 import org.elasticsearch.rest.RestRequest;
@@ -140,14 +139,6 @@ public RestChannelConsumer prepareRequest(final RestRequest request, final NodeC
             throw new IllegalArgumentException("[state] parameter is not supported on all nodes in the cluster");
         }
 
-        // Consume these response parameters used in SnapshotInfo now, to avoid assertion errors in BaseRestHandler for requests where they
-        // may not get used.
-        if (Assertions.ENABLED) {
-            for (final var responseParameter : SUPPORTED_RESPONSE_PARAMETERS) {
-                request.param(responseParameter);
-            }
-        }
-
         return channel -> new RestCancellableNodeClient(client, request.getHttpChannel()).admin()
             .cluster()
             .getSnapshots(getSnapshotsRequest, new RestRefCountedChunkedToXContentListener<>(channel));