Skip to content

Commit 60b36e1

Browse files
committed
SQL: [Tests] Enable integration tests for fixed issues (#40664)
Enable some Ignored integration tests for issues/features that have already been resolved/implemented. (cherry picked from commit c23580f)
1 parent 631cef1 commit 60b36e1

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

x-pack/plugin/sql/qa/src/main/resources/agg.sql-spec

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,18 +51,15 @@ groupByModScalar
5151
SELECT (emp_no % 3) + 1 AS e FROM test_emp GROUP BY e ORDER BY e;
5252

5353
// group by nested functions with no alias
54-
//https://github.com/elastic/elasticsearch/issues/40239
55-
groupByTruncate-Ignore
54+
groupByTruncate
5655
SELECT CAST(TRUNCATE(EXTRACT(YEAR FROM "birth_date")) AS INTEGER) FROM test_emp GROUP BY CAST(TRUNCATE(EXTRACT(YEAR FROM "birth_date")) AS INTEGER) ORDER BY CAST(TRUNCATE(EXTRACT(YEAR FROM "birth_date")) AS INTEGER);
57-
//https://github.com/elastic/elasticsearch/issues/40239
58-
groupByRound-Ignore
56+
groupByRound
5957
SELECT CAST(ROUND(EXTRACT(YEAR FROM "birth_date")) AS INTEGER) FROM test_emp GROUP BY CAST(ROUND(EXTRACT(YEAR FROM "birth_date")) AS INTEGER) ORDER BY CAST(ROUND(EXTRACT(YEAR FROM "birth_date")) AS INTEGER);
6058
groupByAtan2
6159
SELECT ATAN2(YEAR("birth_date"), 5) FROM test_emp GROUP BY ATAN2(YEAR("birth_date"), 5) ORDER BY ATAN2(YEAR("birth_date"), 5);
6260
groupByPower
6361
SELECT POWER(YEAR("birth_date"), 2) FROM test_emp GROUP BY POWER(YEAR("birth_date"), 2) ORDER BY POWER(YEAR("birth_date"), 2);
64-
//https://github.com/elastic/elasticsearch/issues/40239
65-
groupByPowerWithCast-Ignore
62+
groupByPowerWithCast
6663
SELECT CAST(POWER(YEAR("birth_date"), 2) AS DOUBLE) FROM test_emp GROUP BY CAST(POWER(YEAR("birth_date"), 2) AS DOUBLE) ORDER BY CAST(POWER(YEAR("birth_date"), 2) AS DOUBLE);
6764
groupByConcat
6865
SELECT LEFT(CONCAT("first_name", "last_name"), 3) FROM test_emp GROUP BY LEFT(CONCAT("first_name", "last_name"), 3) ORDER BY LEFT(CONCAT("first_name", "last_name"), 3) LIMIT 15;

x-pack/plugin/sql/qa/src/main/resources/select.sql-spec

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,7 @@ selectMathPIFromIndexWithWhereEvaluatingToTrue
108108
SELECT PI() AS pi FROM test_emp WHERE ROUND(PI(),2)=3.14;
109109
selectMathPIFromIndexWithWhereEvaluatingToTrueAndWithLimit
110110
SELECT PI() AS pi FROM test_emp WHERE ROUND(PI(),2)=3.14 LIMIT 3;
111-
// AwaitsFix https://github.com/elastic/elasticsearch/issues/35980
112-
selectMathPIFromIndexWithWhereEvaluatingToFalse-Ignore
111+
selectMathPIFromIndexWithWhereEvaluatingToFalse
113112
SELECT PI() AS pi FROM test_emp WHERE PI()=5;
114-
// AwaitsFix https://github.com/elastic/elasticsearch/issues/35980
115-
selectMathPIFromIndexWithWhereEvaluatingToFalseAndWithLimit-Ignore
113+
selectMathPIFromIndexWithWhereEvaluatingToFalseAndWithLimit
116114
SELECT PI() AS pi FROM test_emp WHERE PI()=5 LIMIT 3;

0 commit comments

Comments
 (0)