Skip to content

Commit 5a5c581

Browse files
committed
Update to AWS SDK 1.11.223 (#27278)
1 parent bda9257 commit 5a5c581

File tree

11 files changed

+41
-28
lines changed

11 files changed

+41
-28
lines changed

docs/plugins/repository-s3.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ The following settings are supported:
216216

217217
`use_throttle_retries`::
218218

219-
Set to `true` if you want to throttle retries. Defaults to AWS SDK default value (`false`).
219+
Set to `true` if you want to throttle retries. Defaults to AWS SDK default value (`true`).
220220

221221
`readonly`::
222222

plugins/repository-s3/build.gradle

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ esplugin {
2323
}
2424

2525
versions << [
26-
'aws': '1.10.69'
26+
'aws': '1.11.223'
2727
]
2828

2929
dependencies {
@@ -83,6 +83,15 @@ thirdPartyAudit.excludes = [
8383
'org.apache.avalon.framework.logger.Logger',
8484
'org.apache.log.Hierarchy',
8585
'org.apache.log.Logger',
86+
'software.amazon.ion.IonReader',
87+
'software.amazon.ion.IonSystem',
88+
'software.amazon.ion.IonType',
89+
'software.amazon.ion.IonWriter',
90+
'software.amazon.ion.Timestamp',
91+
'software.amazon.ion.system.IonBinaryWriterBuilder',
92+
'software.amazon.ion.system.IonSystemBuilder',
93+
'software.amazon.ion.system.IonTextWriterBuilder',
94+
'software.amazon.ion.system.IonWriterBuilder',
8695
]
8796

8897
// jarhell with jdk (intentionally, because jaxb was removed from default modules in java 9)

plugins/repository-s3/licenses/aws-java-sdk-core-1.10.69.jar.sha1

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
c3993cb44f5856fa721b7b7ccfc266377c0bf9c0

plugins/repository-s3/licenses/aws-java-sdk-kms-1.10.69.jar.sha1

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
c24e6ebe108c60a08098aeaad5ae0b6a5a77b618

plugins/repository-s3/licenses/aws-java-sdk-s3-1.10.69.jar.sha1

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
c2ef96732e22d97952fbcd0a94f1dc376d157eda

plugins/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@
1919

2020
package org.elasticsearch.repositories.s3;
2121

22-
import com.amazonaws.AmazonClientException;
2322
import com.amazonaws.services.s3.AmazonS3;
24-
import com.amazonaws.services.s3.model.AmazonS3Exception;
2523
import com.amazonaws.services.s3.model.CannedAccessControlList;
2624
import com.amazonaws.services.s3.model.CreateBucketRequest;
2725
import com.amazonaws.services.s3.model.DeleteObjectsRequest;
@@ -38,6 +36,8 @@
3836
import org.elasticsearch.common.settings.Settings;
3937
import org.elasticsearch.common.unit.ByteSizeValue;
4038

39+
import java.security.AccessController;
40+
import java.security.PrivilegedAction;
4141
import java.util.ArrayList;
4242
import java.util.Locale;
4343

@@ -73,18 +73,22 @@ class S3BlobStore extends AbstractComponent implements BlobStore {
7373
// Also, if invalid security credentials are used to execute this method, the
7474
// client is not able to distinguish between bucket permission errors and
7575
// invalid credential errors, and this method could return an incorrect result.
76-
if (!client.doesBucketExist(bucket)) {
77-
deprecationLogger.deprecated("Auto creation of the bucket for an s3 backed " +
78-
"repository is deprecated and will be removed in 6.0.");
79-
final CreateBucketRequest request;
80-
if (region != null) {
81-
request = new CreateBucketRequest(bucket, region);
82-
} else {
83-
request = new CreateBucketRequest(bucket);
76+
final CannedAccessControlList cAcl = this.cannedACL;
77+
AccessController.doPrivileged((PrivilegedAction<Void>) () -> {
78+
if (!client.doesBucketExist(bucket)) {
79+
deprecationLogger.deprecated("Auto creation of the bucket for an s3 backed " +
80+
"repository is deprecated and will be removed in 6.0.");
81+
final CreateBucketRequest request;
82+
if (region != null) {
83+
request = new CreateBucketRequest(bucket, region);
84+
} else {
85+
request = new CreateBucketRequest(bucket);
86+
}
87+
request.setCannedAcl(cAcl);
88+
client.createBucket(request);
8489
}
85-
request.setCannedAcl(this.cannedACL);
86-
client.createBucket(request);
87-
}
90+
return null;
91+
});
8892
}
8993

9094
@Override

plugins/repository-s3/src/test/java/org/elasticsearch/repositories/s3/AmazonS3Wrapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import com.amazonaws.AmazonWebServiceRequest;
2525
import com.amazonaws.HttpMethod;
2626
import com.amazonaws.regions.Region;
27+
import com.amazonaws.services.s3.AbstractAmazonS3;
2728
import com.amazonaws.services.s3.AmazonS3;
2829
import com.amazonaws.services.s3.S3ClientOptions;
2930
import com.amazonaws.services.s3.S3ResponseMetadata;
@@ -121,15 +122,14 @@
121122
*
122123
*/
123124
@SuppressForbidden(reason = "implements AWS api that uses java.io.File!")
124-
public class AmazonS3Wrapper implements AmazonS3 {
125+
public class AmazonS3Wrapper extends AbstractAmazonS3 {
125126

126127
protected AmazonS3 delegate;
127128

128129
public AmazonS3Wrapper(AmazonS3 delegate) {
129130
this.delegate = delegate;
130131
}
131132

132-
133133
@Override
134134
public void setEndpoint(String endpoint) {
135135
delegate.setEndpoint(endpoint);

0 commit comments

Comments
 (0)