Skip to content

Commit 54e4f24

Browse files
breskebyalbertzaharovits
authored andcommitted
Ignore configs from DistributionDownload plugin and bwc for resolveAllDependencies (#110828)
1 parent e3fce2f commit 54e4f24

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

build-tools/src/main/java/org/elasticsearch/gradle/DistributionDownloadPlugin.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,10 @@ public class DistributionDownloadPlugin implements Plugin<Project> {
4242
private static final String FAKE_SNAPSHOT_IVY_GROUP = "elasticsearch-distribution-snapshot";
4343
private static final String DOWNLOAD_REPO_NAME = "elasticsearch-downloads";
4444
private static final String SNAPSHOT_REPO_NAME = "elasticsearch-snapshots";
45-
public static final String DISTRO_EXTRACTED_CONFIG_PREFIX = "es_distro_extracted_";
46-
public static final String DISTRO_CONFIG_PREFIX = "es_distro_file_";
45+
46+
public static final String ES_DISTRO_CONFIG_PREFIX = "es_distro_";
47+
public static final String DISTRO_EXTRACTED_CONFIG_PREFIX = ES_DISTRO_CONFIG_PREFIX + "extracted_";
48+
public static final String DISTRO_CONFIG_PREFIX = ES_DISTRO_CONFIG_PREFIX + "file_";
4749

4850
private final ObjectFactory objectFactory;
4951
private NamedDomainObjectContainer<ElasticsearchDistribution> distributionsContainer;

build.gradle

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import org.elasticsearch.gradle.internal.info.BuildParams
1919
import org.elasticsearch.gradle.util.GradleUtils
2020
import org.gradle.plugins.ide.eclipse.model.AccessRule
2121
import org.gradle.plugins.ide.eclipse.model.ProjectDependency
22+
import org.elasticsearch.gradle.DistributionDownloadPlugin
2223

2324
import java.nio.file.Files
2425

@@ -284,11 +285,16 @@ allprojects {
284285
}
285286

286287
tasks.register('resolveAllDependencies', ResolveAllDependencies) {
287-
configs = project.configurations
288+
def ignoredPrefixes = [DistributionDownloadPlugin.ES_DISTRO_CONFIG_PREFIX, "jdbcDriver"]
289+
configs = project.configurations.matching { config -> ignoredPrefixes.any { config.name.startsWith(it) } == false }
288290
resolveJavaToolChain = true
289291
if (project.path.contains("fixture")) {
290292
dependsOn tasks.withType(ComposePull)
291293
}
294+
if (project.path.contains(":distribution:docker")) {
295+
enabled = false
296+
}
297+
292298
}
293299

294300
plugins.withId('lifecycle-base') {

qa/packaging/build.gradle

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,3 @@ tasks.named("test").configure { enabled = false }
3636
tasks.register('destructivePackagingTest') {
3737
dependsOn 'destructiveDistroTest'
3838
}
39-
40-
tasks.named('resolveAllDependencies') {
41-
// avoid resolving all elasticsearch distros
42-
enabled = false
43-
}

0 commit comments

Comments
 (0)