Skip to content

Commit 4a5d317

Browse files
authored
Some progress on failing runtime fields tests (#61098)
This breaks apart the a test for the `terms` aggregation into one that work for runtime fields and one that doesn't.
1 parent eeb4afb commit 4a5d317

File tree

2 files changed

+34
-4
lines changed
  • rest-api-spec/src/main/resources/rest-api-spec/test/search.aggregation
  • x-pack/plugin/runtime-fields/qa/rest

2 files changed

+34
-4
lines changed

rest-api-spec/src/main/resources/rest-api-spec/test/search.aggregation/20_terms.yml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -695,6 +695,36 @@ setup:
695695

696696
- match: { indices.test_1.total.fielddata.memory_size_in_bytes: 0}
697697

698+
---
699+
"Global ordinals are loaded with the global_ordinals execution hint":
700+
701+
- do:
702+
index:
703+
refresh: true
704+
index: test_1
705+
id: 1
706+
routing: 1
707+
body: { "str": "abc" }
708+
709+
- do:
710+
index:
711+
refresh: true
712+
index: test_1
713+
id: 2
714+
routing: 1
715+
body: { "str": "abc" }
716+
717+
- do:
718+
index:
719+
refresh: true
720+
index: test_1
721+
id: 3
722+
routing: 1
723+
body: { "str": "bcd" }
724+
725+
- do:
726+
indices.refresh: {}
727+
698728
- do:
699729
search:
700730
index: test_1

x-pack/plugin/runtime-fields/qa/rest/build.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,17 @@ yamlRestTest {
2626
[
2727
/////// TO FIX ///////
2828
'search/330_fetch_fields/*', // The whole API is not yet supported
29-
'search.aggregation/20_terms/Global ordinals are not loaded with the map execution hint', // Broken. Gotta fix.
30-
'search.highlight/40_keyword_ignore/Plain Highligher should skip highlighting ignored keyword values', // Broken. Gotta fix.
29+
'search.highlight/40_keyword_ignore/Plain Highligher should skip highlighting ignored keyword values', // The plain highlighter is incompatible with runtime fields. Worth fixing?
3130
'search/115_multiple_field_collapsing/two levels fields collapsing', // Broken. Gotta fix.
32-
'search/140_pre_filter_search_shards/pre_filter_shard_size with shards that have no hit', // Broken. Gotta fix.
3331
'field_caps/30_filter/Field caps with index filter', // We don't support filtering field caps on runtime fields. What should we do?
3432
'search.aggregation/10_histogram/*', // runtime_script doesn't support sub-fields. Maybe it should?
3533
/////// TO FIX ///////
3634

3735
/////// NOT SUPPORTED ///////
3836
'search.aggregation/280_rare_terms/*', // Requires an index and we won't have it
39-
'search.aggregation/20_terms/string profiler via global ordinals', // Runtime fields don't have global ords
37+
// Runtime fields don't have global ords
38+
'search.aggregation/20_terms/string profiler via global ordinals',
39+
'search.aggregation/20_terms/Global ordinals are loaded with the global_ordinals execution hint',
4040
/////// NOT SUPPORTED ///////
4141
].join(',')
4242
}

0 commit comments

Comments
 (0)