Skip to content

Commit 32b1016

Browse files
committed
Adding getBuilderPrototype() method to all QueryParsers
1 parent f1a6858 commit 32b1016

File tree

94 files changed

+653
-10
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

94 files changed

+653
-10
lines changed

src/main/java/org/elasticsearch/index/query/AndQueryParser.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@
3636
@Deprecated
3737
public class AndQueryParser extends BaseQueryParserTemp {
3838

39+
private static final AndQueryBuilder AND_QUERY_BUILDER = new AndQueryBuilder();
40+
3941
@Inject
4042
public AndQueryParser() {
4143
}
@@ -115,4 +117,9 @@ public Query parse(QueryParseContext parseContext) throws IOException, QueryPars
115117
}
116118
return query;
117119
}
120+
121+
@Override
122+
public AndQueryBuilder getBuilderPrototype() {
123+
return AND_QUERY_BUILDER;
124+
}
118125
}

src/main/java/org/elasticsearch/index/query/BoolQueryParser.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@
3939
*/
4040
public class BoolQueryParser extends BaseQueryParserTemp {
4141

42+
private static final BoolQueryBuilder BOOL_QUERY_BUILDER = new BoolQueryBuilder();
43+
4244
@Inject
4345
public BoolQueryParser(Settings settings) {
4446
BooleanQuery.setMaxClauseCount(settings.getAsInt("index.query.bool.max_clause_count", settings.getAsInt("indices.query.bool.max_clause_count", BooleanQuery.getMaxClauseCount())));
@@ -171,4 +173,9 @@ public Query parse(QueryParseContext parseContext) throws IOException, QueryPars
171173
}
172174
return query;
173175
}
176+
177+
@Override
178+
public BoolQueryBuilder getBuilderPrototype() {
179+
return BOOL_QUERY_BUILDER;
180+
}
174181
}

src/main/java/org/elasticsearch/index/query/BoostingQueryBuilder.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ public class BoostingQueryBuilder extends QueryBuilder implements BoostableQuery
4848
private float boost = -1;
4949

5050
public BoostingQueryBuilder() {
51-
5251
}
5352

5453
public BoostingQueryBuilder positive(QueryBuilder positiveQuery) {

src/main/java/org/elasticsearch/index/query/BoostingQueryParser.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
*/
3232
public class BoostingQueryParser extends BaseQueryParserTemp {
3333

34+
private static final BoostingQueryBuilder BOOSTING_QUERY_BUILDER = new BoostingQueryBuilder();
35+
3436
@Inject
3537
public BoostingQueryParser() {
3638
}
@@ -98,4 +100,9 @@ public Query parse(QueryParseContext parseContext) throws IOException, QueryPars
98100
}
99101
return boostingQuery;
100102
}
103+
104+
@Override
105+
public BoostingQueryBuilder getBuilderPrototype() {
106+
return BOOSTING_QUERY_BUILDER;
107+
}
101108
}

src/main/java/org/elasticsearch/index/query/CommonTermsQueryBuilder.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,14 @@ public CommonTermsQueryBuilder(String name, Object text) {
8686
this.name = name;
8787
}
8888

89+
/**
90+
* package private constructor used for serialization only
91+
*/
92+
CommonTermsQueryBuilder() {
93+
this.name = null;
94+
this.text = null;
95+
}
96+
8997
/**
9098
* Sets the operator to use for terms with a high document frequency
9199
* (greater than or equal to {@link #cutoffFrequency(float)}. Defaults to

src/main/java/org/elasticsearch/index/query/CommonTermsQueryParser.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@
3939
*/
4040
public class CommonTermsQueryParser extends BaseQueryParserTemp {
4141

42+
private static final CommonTermsQueryBuilder COMMON_TERMS_QUERY_BUILDER = new CommonTermsQueryBuilder();
43+
4244
static final float DEFAULT_MAX_TERM_DOC_FREQ = 0.01f;
4345

4446
static final Occur DEFAULT_HIGH_FREQ_OCCUR = Occur.SHOULD;
@@ -219,4 +221,9 @@ private final Query parseQueryString(ExtendedCommonTermsQuery query, String quer
219221
query.setHighFreqMinimumNumberShouldMatch(highFreqMinimumShouldMatch);
220222
return query;
221223
}
224+
225+
@Override
226+
public CommonTermsQueryBuilder getBuilderPrototype() {
227+
return COMMON_TERMS_QUERY_BUILDER;
228+
}
222229
}

src/main/java/org/elasticsearch/index/query/ConstantScoreQueryBuilder.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,13 @@ public ConstantScoreQueryBuilder(QueryBuilder filterBuilder) {
4747
this.filterBuilder = Objects.requireNonNull(filterBuilder);
4848
}
4949

50+
/**
51+
* package private constructor used for serialization
52+
*/
53+
ConstantScoreQueryBuilder() {
54+
this.filterBuilder = null;
55+
}
56+
5057
/**
5158
* Sets the boost for this query. Documents matching this query will (in addition to the normal
5259
* weightings) have their score multiplied by the boost provided.

src/main/java/org/elasticsearch/index/query/ConstantScoreQueryParser.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
*/
3434
public class ConstantScoreQueryParser extends BaseQueryParserTemp {
3535

36+
private static final ConstantScoreQueryBuilder CONSTANT_SCORE_QUERY_BUILDER = new ConstantScoreQueryBuilder();
3637
private static final ParseField INNER_QUERY_FIELD = new ParseField("filter", "query");
3738

3839
@Inject
@@ -86,4 +87,9 @@ public Query parse(QueryParseContext parseContext) throws IOException, QueryPars
8687
filter.setBoost(boost);
8788
return filter;
8889
}
90+
91+
@Override
92+
public ConstantScoreQueryBuilder getBuilderPrototype() {
93+
return CONSTANT_SCORE_QUERY_BUILDER;
94+
}
8995
}

src/main/java/org/elasticsearch/index/query/DisMaxQueryParser.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@
3535
*/
3636
public class DisMaxQueryParser extends BaseQueryParserTemp {
3737

38+
private static final DisMaxQueryBuilder DIS_MAX_QUERY_BUILDER = new DisMaxQueryBuilder();
39+
3840
@Inject
3941
public DisMaxQueryParser() {
4042
}
@@ -111,4 +113,9 @@ public Query parse(QueryParseContext parseContext) throws IOException, QueryPars
111113
}
112114
return query;
113115
}
116+
117+
@Override
118+
public DisMaxQueryBuilder getBuilderPrototype() {
119+
return DIS_MAX_QUERY_BUILDER;
120+
}
114121
}

src/main/java/org/elasticsearch/index/query/ExistsQueryBuilder.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,12 @@ public ExistsQueryBuilder(String name) {
3838
this.name = name;
3939
}
4040

41+
/**
42+
* package private constructor used for serialization
43+
*/
44+
ExistsQueryBuilder() {
45+
}
46+
4147
/**
4248
* Sets the query name for the query that can be used when searching for matched_queries per hit.
4349
*/

0 commit comments

Comments
 (0)