Skip to content

Commit 02c9e2a

Browse files
committed
Fix incorrect assertions in CollapsingTopDocsCollectorSearchAfterTests
These assertions were simply wrong, but took time to catch as they were very rarely triggered. Fixes #75736.
1 parent 8082bbb commit 02c9e2a

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

server/src/test/java/org/apache/lucene/grouping/CollapsingTopDocsCollectorSearchAfterTests.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,10 +133,11 @@ private <T extends Comparable<T>> void assertSearchCollapse(CollapsingDocValuesP
133133
currentValue = fieldDoc.fields[0];
134134
}
135135

136-
if (docsWithMissingField == false) {
137-
assertEquals(expectedNumGroups, collapseTopFieldDocs.scoreDocs.length - 1);
138-
assertEquals(topDocs.scoreDocs.length - 1, topDocsIndex);
136+
for (; topDocsIndex < topDocs.scoreDocs.length; topDocsIndex++) {
137+
FieldDoc fieldDoc = (FieldDoc) topDocs.scoreDocs[topDocsIndex];
138+
assertEquals(fieldDoc.fields[0], currentValue);
139139
}
140+
140141
w.close();
141142
reader.close();
142143
dir.close();

0 commit comments

Comments
 (0)