Skip to content

Move inference examples to appropriate task types #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Mar 21, 2025

Relates to #3545

The only thing left in the specification/inference/inference folder was the request and response body examples.
This PR moves those examples to the appropriate task-specific folders.

@lcawl lcawl requested a review from a team March 21, 2025 16:40
@lcawl lcawl marked this pull request as ready for review March 21, 2025 16:40
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.completion Missing test Missing test
inference.rerank Missing test Missing test
inference.sparse_embedding Missing test Missing test
inference.text_embedding Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit ae85ae3 into main Mar 24, 2025
16 checks passed
@lcawl lcawl deleted the inference-task-reorient branch March 24, 2025 16:13
github-actions bot pushed a commit that referenced this pull request Mar 24, 2025
github-actions bot pushed a commit that referenced this pull request Mar 24, 2025
github-actions bot pushed a commit that referenced this pull request Mar 24, 2025
lcawl added a commit that referenced this pull request Mar 24, 2025
(cherry picked from commit ae85ae3)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Mar 24, 2025
(cherry picked from commit ae85ae3)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Mar 24, 2025
(cherry picked from commit ae85ae3)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants