-
Notifications
You must be signed in to change notification settings - Fork 102
Add Delete geoip database configuration API #2824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-2824-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 21ef23261b8bcfd6fbb544ab5df8484b3e86e039
# Push it to GitHub
git push --set-upstream origin backport-2824-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15 Then, create a pull request where the |
(cherry picked from commit 21ef232)
/** | ||
* A comma-separated list of geoip database configurations to delete | ||
*/ | ||
id?: Ids |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pquentin Is this really an optional parameter? This triggered a validation rule in my code generator.
The rule requires a mandatory parameter to be used in all available urls for an endpoint and an optional parameter to not be used in all available urls for an endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently have only one url for this endpoint:
"urls": [
{
"methods": [
"DELETE"
],
"path": "/_ingest/geoip/database/{id}"
}
]
In other words: If that endpoint does not support an additional url like "/_ingest/geoip/database"
(without the {id}
), we should make the path parameter mandatory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! #2837 fixes it.
Part of #2810, like #2815 and #2823. There's an output conflict with #2823 that I will fix when one of the two will have been merged.