Skip to content

Add descriptions for cat APIs #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Add descriptions for cat APIs #2124

merged 4 commits into from
Jun 5, 2023

Conversation

@lcawl lcawl marked this pull request as ready for review May 24, 2023 18:12
@lcawl lcawl marked this pull request as draft May 24, 2023 18:13
@lcawl lcawl marked this pull request as ready for review May 24, 2023 18:15
@lcawl lcawl requested a review from sethmlarson May 24, 2023 20:05
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lisa! Can you open a separate issue for the CatCommonQueryParameters not getting picked up by validation-errors?

@sethmlarson
Copy link
Contributor

@lcawl Also can you resolve the merge conflict and rebuild with make contrib?

@lcawl
Copy link
Contributor Author

lcawl commented Jun 5, 2023

Thanks Lisa! Can you open a separate issue for the CatCommonQueryParameters not getting picked up by validation-errors?

Done! I created #2136

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cat.aliases 🟢 24/24 24/24
cat.allocation 🟢 10/10 10/10
cat.component_templates Missing test Missing test
cat.count 🟢 9/9 9/9
cat.fielddata 🟢 6/6 6/6
cat.health 🟢 5/5 5/5
cat.indices 🟢 33/33 32/32
cat.ml_data_frame_analytics 🟢 5/5 5/5

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit 328513c into main Jun 5, 2023
@lcawl lcawl deleted the cat-apis branch June 5, 2023 16:03
swallez pushed a commit that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants