Skip to content

Commit ec139fb

Browse files
authored
Add more instructions against PRs from forks (#4738)
1 parent c4b55cb commit ec139fb

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Documents under the docs/ directory will help you to change the specification. T
3939
* [Fixing a definition, the complete story](docs/validation-example.md)
4040

4141

42-
## Send your pull request
42+
## Send your pull request from a branch
4343

4444
To fix any style issues and generate the outputs (that we store in git), please run:
4545

@@ -56,5 +56,4 @@ Then, follow those steps:
5656
- If the API is unusable without the change -> every supported version
5757
- If the API is usable, but fix is on the response side -> every supported version
5858
- If the API is usable, but fix is on the request side -> no backport, unless the API is _partially_ usable and the fix unlocks a missing feature that has no workaround
59-
60-
59+
- Send the pull request from a branch, **not a fork**

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ If you need to download the recordings again, run `make validate-no-cache api=xp
250250

251251
Once you see the errors, you can fix the original definition in `/specification`
252252
and then run the command again until the types validator does not trigger any new error.
253-
Finally open a pull request with your changes.
253+
Finally open a pull request with your changes. Please open it from a branch in the repository, and not from a fork.
254254

255255
## Documentation
256256

0 commit comments

Comments
 (0)