Test Runner: Catch Net::ReadTimeout when retrying actions

elastic · Jul 23, 2024 · 95dd5b7 · 95dd5b7
1 parent dddf9b6
commit 95dd5b7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/elasticsearch-api/api-spec-testing/test_file.rb b/elasticsearch-api/api-spec-testing/test_file.rb
@@ -162,6 +162,7 @@ def run_actions_and_retry(actions)
               action.execute(client)
               true
             rescue Elastic::Transport::Transport::Errors::RequestTimeout,
+                   Net::ReadTimeout, # TODO: Replace this if we change adapters
                    Elastic::Transport::Transport::Errors::ServiceUnavailable => e
               # The action sometimes gets the cluster in a recovering state, so we
               # retry a few times and then raise an exception if it's still

diff --git a/elasticsearch-api/spec/elasticsearch/api/perform_request_spec.rb b/elasticsearch-api/spec/elasticsearch/api/perform_request_spec.rb
@@ -58,7 +58,7 @@
         if defined_path_parts.empty?
           { endpoint: spec.endpoint_name }
         else
-          { endpoint: spec.endpoint_name, defined_params:  defined_path_parts}
+          { endpoint: spec.endpoint_name, defined_params: defined_path_parts }
         end
       end
 

diff --git a/elasticsearch/spec/integration/opentelemetry_spec.rb b/elasticsearch/spec/integration/opentelemetry_spec.rb
@@ -36,12 +36,12 @@
     end
 
     after do
-     client.delete(index: 'myindex', id: 1); rescue
+      client.delete(index: 'myindex', id: 1); rescue
     end
 
     context 'when a request is instrumented' do
       it 'sets the span name to the endpoint id' do
-        client.search(body: { query: { match: {a: 1} } })
+        client.search(body: { query: { match: { a: 1 } } })
         expect(span.name).to eq 'search'
       end