[STORE] Remove #with method

Author: estolfo

elasticsearch-persistence/lib/elasticsearch/persistence/repository.rb

@@ -119,27 +119,6 @@ def initialize(options = {})
         @options = options
       end
 
-      # Get a new instance of this repository with different options.
-      # Any options that are not passed into the method will be kept from the original instance.
-      #
-      # Provides a new repository object with the passed options merged over the existing
-      # options of this repository. Useful for one-offs to change specific options
-      # without altering the original repository itself.
-      #
-      # @example Get a repository with changed options.
-      #   repository.with(index_name: 'other_index')
-      #
-      # @param [ Hash ] new_options The new options to use.
-      #
-      # @return [ Elasticsearch::Persistence::Repository ] A new repository instance.
-      #
-      # @since 6.0.0
-      def with(new_options = {})
-        clone.tap do |repository|
-          repository.options.update(new_options)
-        end
-      end
-
       # Get the client used by the repository.
       #
       # @example

elasticsearch-persistence/spec/repository/find_spec.rb

@@ -99,8 +99,6 @@
                                               { 'a' => 1 },
                                               { 'a' => 2 }])
         end
-
-
       end
 
       context 'when the document cannot be found' do
@@ -149,7 +147,7 @@
     context 'when a document_type is defined on the class' do
 
       let(:repository) do
-        DEFAULT_REPOSITORY.with(document_type:'other_type', client: DEFAULT_CLIENT)
+        MyTestRepository.new(document_type:'other_type', client: DEFAULT_CLIENT)
       end
 
       let!(:ids) do

elasticsearch-persistence/spec/repository/search_spec.rb

@@ -53,7 +53,7 @@
     context 'when the repository does have a type set' do
 
       let(:repository) do
-        DEFAULT_REPOSITORY.with(document_type: 'other_note')
+        MyTestRepository.new(document_type: 'other_note')
       end
 
       before do
@@ -126,7 +126,7 @@
     context 'when the repository does have a type set' do
 
       let(:repository) do
-        DEFAULT_REPOSITORY.with(document_type: 'other_note')
+        MyTestRepository.new(document_type: 'other_note')
       end
 
       before do

elasticsearch-persistence/spec/repository/serialize_spec.rb

@@ -31,7 +31,7 @@ def to_hash
 
       let(:repository) do
         require 'set'
-        DEFAULT_REPOSITORY.with(klass: Set)
+        MyTestRepository.new(klass: Set)
       end
 
       it 'instantiates an object of the klass' do

elasticsearch-persistence/spec/repository_spec.rb

@@ -71,55 +71,6 @@ class UserRepo
     end
   end
 
-  describe '#with' do
-
-    let(:repository) do
-      UserRepo.new(index_name: 'users', document_type: 'user', klass: Hash)
-    end
-
-    context 'when all the options are changed' do
-
-      let(:new_repository) do
-        repository.with(index_name: 'other_users',
-                        document_type: 'other_user',
-                        klass: Array,
-                        client: double('client)', class: Elasticsearch::Transport::Client))
-      end
-
-      it 'changes the options' do
-        expect(new_repository.index_name).to eq('other_users')
-        expect(new_repository.document_type).to eq('other_user')
-        expect(new_repository.klass).to eq(Array)
-        expect(new_repository.client.class).to eq(Elasticsearch::Transport::Client)
-      end
-
-      it 'returns a new instance of the repository class' do
-        expect(new_repository).not_to be(repository)
-      end
-
-      it 'clones the options' do
-        expect(new_repository.options).not_to be(repository.options)
-      end
-    end
-
-    context 'when only some options are changed' do
-
-      let(:new_repository) do
-        repository.with(index_name: 'other_users')
-      end
-
-      it 'only changes the new option' do
-        expect(new_repository.index_name).to eq('other_users')
-        expect(new_repository.document_type).to eq('user')
-        expect(new_repository.klass).to eq(Hash)
-      end
-
-      it 'returns a new instance of the repository class' do
-        expect(new_repository).not_to be(repository)
-      end
-    end
-  end
-
   describe 'class methods' do
 
     before(:all) do
@@ -402,10 +353,6 @@ class NoteRepository
         expect(NoteRepository.new(mapping: double('mapping', to_hash: { note: {} })).mapping.to_hash).to eq(note: {})
       end
 
-      it 'allows the value to be overwritten when #with is called on an instance' do
-        expect(NoteRepository.new.with(mapping: double('mapping', to_hash: { note: {} })).mapping.to_hash).to eq(note: {})
-      end
-
       context 'when the instance has a different document type' do
 
         let(:expected_mapping) do
@@ -418,7 +365,7 @@ class NoteRepository
         end
 
         it 'updates the mapping to use the document type' do
-          expect(NoteRepository.new.with(document_type: 'other_note').mapping.to_hash).to eq(expected_mapping)
+          expect(NoteRepository.new(document_type: 'other_note').mapping.to_hash).to eq(expected_mapping)
         end
       end
     end
@@ -436,10 +383,6 @@ class NoteRepository
       it 'allows the value to be overwritten with options on the instance' do
         expect(NoteRepository.new(settings: { number_of_shards: 3 }).settings.to_hash).to eq({ number_of_shards: 3 })
       end
-
-      it 'allows the value to be overwritten when #with is called on an instance' do
-        expect(NoteRepository.new.with(settings: { number_of_shards: 3 }).settings.to_hash).to eq({ number_of_shards: 3 })
-      end
     end
   end
 end