Skip to content

Update index.rst #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Update index.rst #771

merged 1 commit into from
Apr 24, 2018

Conversation

h2ri
Copy link
Contributor

@h2ri h2ri commented Apr 17, 2018

While es.index is called there is no key name "created" so trying to print it would raise a KeyError.
A better key to know the status of the created object would be "result".
Hence the update

@fxdgear
Copy link
Contributor

fxdgear commented Apr 20, 2018

@h2ri thanks for the patch! 👍

Would you mind signing the CLA. Then I'll merge.

Thanks

@h2ri
Copy link
Contributor Author

h2ri commented Apr 20, 2018 via email

@fxdgear
Copy link
Contributor

fxdgear commented Apr 20, 2018

@h2ri if you look at the status of this PR it says you have not signed it. maybe you signed with a different GH account before?

@h2ri
Copy link
Contributor Author

h2ri commented Apr 24, 2018

I Have signed the CLA and got an acknowledgment to my mail with my username of GitHub as h2ri, but the status is not updating.

@h2ri
Copy link
Contributor Author

h2ri commented Apr 24, 2018

@fxdgear Will the status automatically update after the CLA is signed?

@fxdgear
Copy link
Contributor

fxdgear commented Apr 24, 2018

@h2ri yes. it's signed now. thank you!

@fxdgear fxdgear merged commit 0aac8c9 into elastic:master Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants