Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pyarrow dependency optional for tests #2733

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

danigm
Copy link
Contributor

@danigm danigm commented Jan 8, 2025

This change allows to run tests without having pyarrow installed.

Copy link

github-actions bot commented Jan 8, 2025

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@pquentin
Copy link
Member

pquentin commented Jan 8, 2025

buildkite test this please

@pquentin pquentin closed this Jan 8, 2025
@pquentin pquentin reopened this Jan 8, 2025
@danigm
Copy link
Contributor Author

danigm commented Jan 8, 2025

I've just fixed the lint issues. Sorry, I override your commit fixing the lint, we did it at the same time and I just amend.

@pquentin pquentin closed this Jan 8, 2025
@pquentin pquentin reopened this Jan 8, 2025
@pquentin
Copy link
Member

pquentin commented Jan 8, 2025

buildkite test this please

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@pquentin
Copy link
Member

pquentin commented Jan 8, 2025

I fixed the lint with nox -rs format, please don't force push again :)

@pquentin
Copy link
Member

pquentin commented Jan 8, 2025

buildkite test this please

@pquentin pquentin merged commit d692c70 into elastic:main Jan 8, 2025
14 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
@pquentin
Copy link
Member

pquentin commented Jan 8, 2025

Thank you for your contribution! And sorry for pushing to your branch.

@danigm danigm deleted the optional-pyarrow branch January 8, 2025 12:13
pquentin pushed a commit that referenced this pull request Jan 8, 2025
(cherry picked from commit d692c70)

Co-authored-by: danigm <daniel.garcia@suse.com>
pquentin pushed a commit that referenced this pull request Jan 8, 2025
(cherry picked from commit d692c70)

Co-authored-by: danigm <daniel.garcia@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants