detect more boolean types for boolean|long api type #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
I'd like to add tests for this but I'm not sure where to begin. |
Grinnz
force-pushed
the
api-boolean-detection
branch
from
ea567d2 to
ee6a134
Compare
Grinnz
force-pushed
the
api-boolean-detection
branch
from
ee6a134 to
45184ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested fix for #245 by inverting the logic, since looks_like_number accepts too many valid inputs. Attempts to detect a boolean first, and only if that does not return true or false, return a number.
Additionally expands boolean detection using is_bool from JSON::MaybeXS (notably this supports the new builtin booleans, which on recent Perls can be returned by builtin::true or operators such as
!).