Skip to content

Change SumOfDocumentFrequencies and SumOfTotalTermFrequencies to long #4600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2020
Merged

Change SumOfDocumentFrequencies and SumOfTotalTermFrequencies to long #4600

merged 1 commit into from
Apr 17, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Apr 16, 2020

This commit changes the SumOfDocumentFrequencies and SumOfTotalTermFrequencies
on TermVector to long. These values can be bigger than int.

Fixes #4578

@russcam
Change SumOfDocumentFrequencies and SumOfTotalTermFrequencies to long
9ca3893 
This commit changes the SumOfDocumentFrequencies and SumOfTotalTermFrequencies
on TermVector to long. These values can be bigger than int.

Fixes #4578
Mpdreamz
Mpdreamz approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to see it backported too even if technically breaking

@russcam russcam merged commit a96581c into master Apr 17, 2020
@russcam russcam deleted the fix/field-stats branch April 17, 2020 05:12
github-actions bot pushed a commit that referenced this pull request Apr 17, 2020
@russcam @github-actions
Change SumOfDocumentFrequencies and SumOfTotalTermFrequencies to long (…
b4c1167 
…#4600)

This commit changes the SumOfDocumentFrequencies and SumOfTotalTermFrequencies
on TermVector to long. These values can be bigger than int.

Fixes #4578
@github-actions github-actions bot mentioned this pull request Apr 17, 2020
Merged
github-actions bot pushed a commit that referenced this pull request Apr 17, 2020
@russcam @github-actions
Change SumOfDocumentFrequencies and SumOfTotalTermFrequencies to long (…
a02505e 
…#4600)

This commit changes the SumOfDocumentFrequencies and SumOfTotalTermFrequencies
on TermVector to long. These values can be bigger than int.

Fixes #4578
@github-actions github-actions bot mentioned this pull request Apr 17, 2020
Merged
russcam added a commit that referenced this pull request Apr 17, 2020
@russcam
Change SumOfDocumentFrequencies and SumOfTotalTermFrequencies to long (…
c2a81c3 
…#4600)

This commit changes the SumOfDocumentFrequencies and SumOfTotalTermFrequencies
on TermVector to long. These values can be bigger than int.

Fixes #4578

(cherry picked from commit a96581c)
russcam added a commit that referenced this pull request May 7, 2020
@russcam
Change SumOfDocumentFrequencies and SumOfTotalTermFrequencies to long (…
3cb3ed3 
…#4600)

This commit changes the SumOfDocumentFrequencies and SumOfTotalTermFrequencies
on TermVector to long. These values can be bigger than int.

Fixes #4578

(cherry picked from commit b4c1167)
@russcam russcam added v7.6.2 and removed v7.7.0 labels May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
Breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FieldStatistics.cs class has int values but can get from indexes long values
2 participants
@russcam @Mpdreamz