-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix GetMany when no default index is set #4463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#4353 Fixed an issue with the GetMany helpers that returned the cartesian product of all ids specified rather then creating a distinct list if more then one index was targeted. This PR also updated the routine in the serializer to omit the index name from each item if the index is already specified on the url in case of multiple indices This updated routine in the `7.6.0` could throw if you are calling: client.GetMany<T>(ids, "indexName"); Without configuring `ConnectionSettings()` with either a default index for T or a global default index.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-6.x 6.x
# Navigate to the new working tree
cd .worktrees/backport-6.x
# Create a new branch
git switch --create backport-4463-to-6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 87c8cdd05ba3ef3818e6cd3444bd71b5de84d443
# Push it to GitHub
git push --set-upstream origin backport-4463-to-6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-6.x Then, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2020
#4353 Fixed an issue with the GetMany helpers that returned the cartesian product of all ids specified rather then creating a distinct list if more then one index was targeted. This PR also updated the routine in the serializer to omit the index name from each item if the index is already specified on the url in case of multiple indices This updated routine in the `7.6.0` could throw if you are calling: client.GetMany<T>(ids, "indexName"); Without configuring `ConnectionSettings()` with either a default index for T or a global default index.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2020
#4353 Fixed an issue with the GetMany helpers that returned the cartesian product of all ids specified rather then creating a distinct list if more then one index was targeted. This PR also updated the routine in the serializer to omit the index name from each item if the index is already specified on the url in case of multiple indices This updated routine in the `7.6.0` could throw if you are calling: client.GetMany<T>(ids, "indexName"); Without configuring `ConnectionSettings()` with either a default index for T or a global default index.
Mpdreamz
added a commit
that referenced
this pull request
Feb 26, 2020
#4353 Fixed an issue with the GetMany helpers that returned the cartesian product of all ids specified rather then creating a distinct list if more then one index was targeted. This PR also updated the routine in the serializer to omit the index name from each item if the index is already specified on the url in case of multiple indices This updated routine in the `7.6.0` could throw if you are calling: client.GetMany<T>(ids, "indexName"); Without configuring `ConnectionSettings()` with either a default index for T or a global default index. (cherry picked from commit 87c8cdd)
Mpdreamz
added a commit
that referenced
this pull request
Feb 26, 2020
#4353 Fixed an issue with the GetMany helpers that returned the cartesian product of all ids specified rather then creating a distinct list if more then one index was targeted. This PR also updated the routine in the serializer to omit the index name from each item if the index is already specified on the url in case of multiple indices This updated routine in the `7.6.0` could throw if you are calling: client.GetMany<T>(ids, "indexName"); Without configuring `ConnectionSettings()` with either a default index for T or a global default index. (cherry picked from commit 87c8cdd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4353
Fixed an issue with the GetMany helpers that returned the cartesian product of all ids specified rather
then creating a distinct list if more then one index was targeted.
This PR also updated the routine in the serializer to omit the index name from each item if the index is
already specified on the url in case of multiple indices
This updated routine in the
7.6.0
could throw if you are calling:Without configuring
ConnectionSettings()
with either a default index for T or a global default index.