Skip to content

Implement shape queries. #4155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2019

Conversation

codebrain
Copy link
Contributor

Depends on PR: #4154

Implements: elastic/elasticsearch#45108

@codebrain codebrain mentioned this pull request Oct 17, 2019
56 tasks
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, needs some skipversion attributes and a pass over the docs.

if (q.Field.IsConditionless())
return true;

switch (q.Shape)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return switch c# 8.0 👍

@codebrain codebrain merged commit cbc6a08 into feature/7.x/shape-mapping Oct 18, 2019
@codebrain codebrain deleted the feature/7.x/shape-queries branch October 18, 2019 03:36
codebrain added a commit that referenced this pull request Oct 18, 2019
Implement shape queries.
codebrain added a commit that referenced this pull request Oct 18, 2019
Implement shape property type mapping and shape queries.
@codebrain
Copy link
Contributor Author

Ported to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants