Skip to content

Date Nanos implementation #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 16, 2019
Merged

Date Nanos implementation #3933

merged 11 commits into from
Jul 16, 2019

Conversation

codebrain
Copy link
Contributor

@codebrain codebrain commented Jul 9, 2019 •
edited
Loading

Add nanosecond field mapper

elastic/elasticsearch#37755

russcam and others added 5 commits July 4, 2019 14:57
@russcam
Serialize only script in script_score function (#3909)
a49fc63 
This commit updates the ScoreFunctionJsonFormatter to serialize only the
script inside of the script_score JSON object.

Fixes #3904

(cherry picked from commit ac60472)
@russcam
Include time zone information for Local and Utc DateTimeKind (#3910)
6fe6961 
This commit adds the time zone information for a DateTime within a DateMath type, when the DateTimeKind is Local or Utc. This behaviour aligns 7.x with 6.x.

Introduce StringBuilderCache for caching a StringBuilder per thread. Use of this can be extended in a later commit.

Fixes #3899
@russcam
Do not set HttpRequestMessage content when no PostData (#3925)
329e03d 
This commit changes the HttpConnection to not set Content on HttpRequestMessage when there is no PostData. The check is performed inside of Request and RequestAsync to avoid creating any content instance and allocations.

Pass RequestData through to _onStreamAvailable delegates so that HttpCompression, ConnectionSettings and PostData can be accessed on the passed instance.

Fixes #3907

(cherry picked from commit 90c2bf7)
@russcam
Support numbers with exponent in WKT (#3922)
865e1b9 
This commit provides support for numbers with an exponent when reading WKT.

Fixes #3920

(cherry picked from commit 8386d4c)
@codebrain
Date Nanos implementation
2c43ae2
@codebrain codebrain mentioned this pull request Jul 9, 2019
Closed
17 tasks
russcam
russcam suggested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a comment.

PropertyFormatter also needs to be updated to deserialize date_nanos, and there should be some unit/integration tests.

@russcam
Copy link
Contributor

russcam commented Jul 15, 2019

@codebrain this needs some tests too, similar to https://github.com/elastic/elasticsearch-net/blob/9f0d285904d4c2dc523b8bbc835535662d83f547/src/Tests/Tests/Mapping/Types/Core/Date/DatePropertyTests.cs

russcam
russcam approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a small comment

codebrain
codebrain commented Jul 16, 2019
View reviewed changes
@codebrain codebrain changed the base branch from 7.1 to master July 16, 2019 09:21
@codebrain codebrain merged commit 806c928 into master Jul 16, 2019
codebrain added a commit that referenced this pull request Jul 16, 2019
@codebrain
Date Nanos implementation (#3933)
f55ccd3 
This datatype is an addition to the date datatype.

However there is an important distinction between the two. The existing date datatype stores dates in millisecond resolution. The date_nanos data type stores dates in nanosecond resolution, which limits its range of dates from roughly 1970 to 2262, as dates are still stored as a long representing nanoseconds since the epoch.
@russcam russcam deleted the feature/7.1/date-nanos branch July 24, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russcam russcam russcam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebrain @russcam