Implement Api Key authorisation on requests #3912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
reviewed
Jul 3, 2019
src/Elasticsearch.Net/Configuration/Security/ApiKeyAuthenticationCredentials.cs
Show resolved
Hide resolved
Mpdreamz
requested changes
Jul 3, 2019
russcam
reviewed
Jul 4, 2019
russcam
reviewed
Jul 8, 2019
- Ensure API Key auth details are disposed - Add implementation for HttpConnection - Use API Key in Pings (if available)
codebrain
added a commit
that referenced
this pull request
Jul 16, 2019
Implement Api Key authorisation on requests. In instances where Basic and ApiKey are set, precedence is given to Api Key.
russcam
pushed a commit
that referenced
this pull request
Jul 18, 2019
Implement Api Key authorisation on requests. In instances where Basic and ApiKey are set, precedence is given to Api Key.
codebrain
added a commit
that referenced
this pull request
Jul 19, 2019
Implement Api Key authorisation on requests. In instances where Basic and ApiKey are set, precedence is given to Api Key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to set both the
Basicauth andApiKeyauth together.Clearly this doesn't make sense to do, and to me this feels like an exception.
Should we throw an exception in the client? (which would only surface at runtime), or do we apply some kind of precedence in which auth to apply if both are set?
I also left in the
stringoverride as I think this might be a little easier for someone to use, if they are unable to find our.CreateSecureString()extension method.