Collection deserialisation needs to check for null tokens #3815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpting to deserialise the value. Sql query results are composed of an array of values, with elements that may be null. Fixes #3813
|
Spoke with @codebrain about this change. Will update this PR with a different approach |
Integration test currently failing: Machine Learning - PreviewDatafeedApi
|
Integration test currently failing: |
…der to push generic constraint to code generator
Custom PreviewDatafeedResponseBuilder
russcam
suggested changes
Jun 14, 2019
src/Nest/Cluster/NodesHotThreads/NodeHotThreadsResponseBuilder.cs
Outdated
Show resolved
Hide resolved
src/Nest/XPack/MachineLearning/PreviewDatafeed/PreviewDatafeedResponseBuilder.cs
Show resolved
Hide resolved
src/Nest/XPack/MachineLearning/PreviewDatafeed/PreviewDatafeedResponseBuilder.cs
Show resolved
Hide resolved
russcam
suggested changes
Jun 18, 2019
src/Nest/Cluster/NodesHotThreads/NodeHotThreadsResponseBuilder.cs
Outdated
Show resolved
Hide resolved
src/Nest/Cluster/NodesHotThreads/NodeHotThreadsResponseBuilder.cs
Outdated
Show resolved
Hide resolved
Co-Authored-By: Russ Cam <russ.cam@elastic.co>
Co-Authored-By: Russ Cam <russ.cam@elastic.co>
|
Check for deserialisation of response in the event of an error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sql query results are composed of an array of values, with elements that may be null.
Fixes #3813