Skip to content

Some event do not carry timings information but DebugInformation stil… #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2019

Conversation

Mpdreamz
Copy link
Member

…l tries to display timings information

# Audit trail of this API call:
 - [1] PingFailure: Node: http://localhost:9200/ Exception: PipelineException Took: 00:00:00.1001219
 - [2] PingFailure: Node: http://localhost:9201/ Exception: PipelineException Took: 00:00:00.0012111
 - [3] PingFailure: Node: http://localhost:9202/ Exception: PipelineException Took: 00:00:00.0007504
 - [4] PingFailure: Node: http://localhost:9203/ Exception: PipelineException Took: 00:00:00.0007236
 - [5] PingFailure: Node: http://localhost:9204/ Exception: PipelineException Took: 00:00:00.0007315
 - [6] PingFailure: Node: http://localhost:9205/ Exception: PipelineException Took: 00:00:00.0037279
 - [7] PingFailure: Node: http://localhost:9206/ Exception: PipelineException Took: 00:00:00.0008012
 - [8] PingFailure: Node: http://localhost:9207/ Exception: PipelineException Took: 00:00:00.0009753
 - [9] PingFailure: Node: http://localhost:9208/ Exception: PipelineException Took: 00:00:00.0008170
 - [10] PingFailure: Node: http://localhost:9209/ Exception: PipelineException Took: 00:00:00.0008090
 - [11] MaxRetriesReached:
 - [12] FailedOverAllNodes:

This fixes DebugInformation showing a negative took for the last two events.

Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz merged commit 0fca6d0 into 7.x May 31, 2019
Mpdreamz added a commit that referenced this pull request May 31, 2019
…l tries to display timings information (#3783)

(cherry picked from commit 0fca6d0)
Mpdreamz added a commit that referenced this pull request May 31, 2019
…l tries to display timings information (#3783)

(cherry picked from commit 0fca6d0)
Mpdreamz added a commit that referenced this pull request May 31, 2019
…l tries to display timings information (#3783)

(cherry picked from commit 0fca6d0)
@Mpdreamz Mpdreamz deleted the fix/audit-event-with-no-timing branch May 31, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants