Use a custom convertor for GeoOrientation to tolerate alternative options in Elasticsearch #3776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions in Elasticsearch
Mpdreamz
requested changes
May 28, 2019
|
Including example cluster metadata state with the transformed |
russcam
reviewed
May 29, 2019
| public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer) | ||
| { | ||
| var enumString = (string)reader.Value; | ||
| switch (enumString.ToLower()) |
There was a problem hiding this comment.
think this should use ToLowerInvariant(), rather than use the current culture
There was a problem hiding this comment.
Didn't make the cut for the merge, but will fix for 7.x
codebrain
added a commit
that referenced
this pull request
May 30, 2019
…ions in Elasticsearch #3776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation (https://www.elastic.co/guide/en/elasticsearch/reference/current/geo-shape.html) states that there are multiple values possible; 1. Right-hand rule:
right,ccw,counterclockwise, 2. Left-hand rule:left,cw,clockwise.It looks like NEST only supported
cwandccw.Cluster metadata exposed
cwasLEFTin the responses.