Skip to content

Feature/geo hash filter #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2014
Merged

Conversation

robertlyson
Copy link
Contributor

Hello,

this is short summary what I have done to implement this feature:

I've added new property to GeoPointMapping: GeoHashPrefix.
GeoPointMappingDescriptor has been changed as well.

I've created new classes: GeoHashCellFilter, GeoHashCellFilterDescriptor and GeoHashCellFilterConverter

At the end I've prepared FilterContainer and FilterDescriptor to handle filter.

PS:
These classes contain tests for the issue: GeoHashCellFilterJson and GeoHashCellFilterTests

using Newtonsoft.Json;
using Newtonsoft.Json.Converters;

namespace Nest.DSL.Filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertlyson Typically, we do not fully namespace our public API classes. This should be changed to just Nest.

@gmarz
Copy link
Contributor

gmarz commented Nov 4, 2014

@robertlyson Awesome! Thank you for implementing this. 👍

I left a few minor comments regarding the Nest.DSL.Filter namespace, which is a simple fix. Also, it looks like the build broke when you renamed GeoHashCellFilter.cs:

Source file 'Search\Filter\Singles\GeoHashCellFilter.cs' could not be found

Looks like the rename never made it to the csproj file.

Other than that, this LGTM.

@robertlyson
Copy link
Contributor Author

@gmarz Thank you for your feedback.

I've pushed my fixes.
In case of any questions, let me know.

Thanks.

@gmarz
Copy link
Contributor

gmarz commented Nov 4, 2014

Great, thank you @robertlyson! Changes look good.

One last request, would you mind signing the CLA so we can pull this in?

@robertlyson
Copy link
Contributor Author

@gmarz Done.

gmarz added a commit that referenced this pull request Nov 5, 2014
@gmarz gmarz merged commit 018029a into elastic:develop Nov 5, 2014
@robertlyson robertlyson deleted the feature/GeoHashFilter branch November 6, 2014 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants