Skip to content

Commit aec072b

Browse files
committed
addressed typo's and naming comments from PR review
1 parent ca0ebcc commit aec072b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/Nest/Mapping/Types/Core/Join/JoinField.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@ namespace Nest
66
[JsonConverter(typeof(JoinFieldJsonConverter))]
77
public class JoinField : Union<JoinField.Parent, JoinField.Child>
88
{
9-
public JoinField(Parent parentName) : base(parentName) { }
9+
public JoinField(Parent parent) : base(parent) { }
1010

1111
public JoinField(Child child) : base(child) { }
1212

1313
public static JoinField Root<TParent>() => new Parent(typeof(TParent));
1414
public static JoinField Root(RelationName parent) => new Parent(parent);
1515

16-
public static JoinField Link(RelationName childName, Id parentId) => new Child(childName, parentId);
16+
public static JoinField Link(RelationName child, Id parentId) => new Child(child, parentId);
1717
public static JoinField Link<TChild, TParentDocument>(TParentDocument parent) where TParentDocument : class =>
1818
new Child(typeof(TChild), Id.From<TParentDocument>(parent));
1919
public static JoinField Link<TChild>(Id parentId) => new Child(typeof(TChild), parentId);

src/Tests/ClientConcepts/HighLevel/Inference/TypesAndRelationsInference.doc.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ [U] public void PluralizeTypeNames()
6969
*
7070
* Both `Parent` and `Child` will need to have resolve to the same typename to be indexed into the same index.
7171
*
72-
* Therefor in 6.x we need a different type that translates a CLR type to a join relation. This can be configured seperately
72+
* Therefore in 6.x we need a different type that translates a CLR type to a join relation. This can be configured seperately
7373
* using `.RelationName()`
7474
*/
7575
[U] public void RelationNameConfiguration()

0 commit comments

Comments
 (0)