Remove "_source_include" and "_source_exclude" from overrides (#4070)

codebrain · russcam · commit 6284623ea10e · 2019-09-04T14:15:17.000+10:00
diff --git a/src/CodeGeneration/ApiGenerator/Configuration/Overrides/Endpoints/SearchOverrides.cs b/src/CodeGeneration/ApiGenerator/Configuration/Overrides/Endpoints/SearchOverrides.cs
@@ -15,8 +15,6 @@ public class SearchOverrides : EndpointOverridesBase
 			"q", //we dont support GET searches
 			"sort",
 			"_source",
-			"_source_include",
-			"_source_exclude",
 			"_source_includes",
 			"_source_excludes",
 			"track_scores",
diff --git a/src/CodeGeneration/ApiGenerator/Configuration/Overrides/Endpoints/UpdateOverrides.cs b/src/CodeGeneration/ApiGenerator/Configuration/Overrides/Endpoints/UpdateOverrides.cs
@@ -8,7 +8,6 @@ public class UpdateOverrides : EndpointOverridesBase
 		public override IEnumerable<string> SkipQueryStringParams => new[]
 		{
 			"fields",
-			"_source_include", "_source_exclude",
 			"_source_includes", "_source_excludes"
 		};
 	}
diff --git a/src/CodeGeneration/ApiGenerator/Configuration/Overrides/GlobalOverrides.cs b/src/CodeGeneration/ApiGenerator/Configuration/Overrides/GlobalOverrides.cs
@@ -39,8 +39,7 @@ public class GlobalOverrides : EndpointOverridesBase
 			"parent", //can be removed once https://github.com/elastic/elasticsearch/pull/41098 is in
 			"copy_settings", //this still needs a PR?
 			"source", // allows the body to be specified as a request param, we do not want to advertise this with a strongly typed method
-			"timestamp",
-			"_source_include", "_source_exclude", // can be removed once https://github.com/elastic/elasticsearch/pull/41439 is in
+			"timestamp"
 		};
 	}
 }
diff --git a/src/CodeGeneration/ApiGenerator/Domain/Specification/QueryParameters.cs b/src/CodeGeneration/ApiGenerator/Domain/Specification/QueryParameters.cs
@@ -9,7 +9,7 @@ public class QueryParameters
 	{
 		private static readonly string[] FieldsParams =
 		{
-			"fields", "_source_include", "_source_exclude", "_source_includes", "_source_excludes",
+			"fields", "_source_includes", "_source_excludes",
 		};
 		
 		public bool Skip { get; set; }

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ public class UpdateOverrides : EndpointOverridesBase`
`8`	`8`	`public override IEnumerable<string> SkipQueryStringParams => new[]`
`9`	`9`	`{`
`10`	`10`	`"fields",`
`11`		`- "_source_include", "_source_exclude",`
`12`	`11`	`"_source_includes", "_source_excludes"`
`13`	`12`	`};`
`14`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,7 @@ public class GlobalOverrides : EndpointOverridesBase`
`39`	`39`	`"parent", //can be removed once https://github.com/elastic/elasticsearch/pull/41098 is in`
`40`	`40`	`"copy_settings", //this still needs a PR?`
`41`	`41`	`"source", // allows the body to be specified as a request param, we do not want to advertise this with a strongly typed method`
`42`		`- "timestamp",`
`43`		`- "_source_include", "_source_exclude", // can be removed once https://github.com/elastic/elasticsearch/pull/41439 is in`
	`42`	`+ "timestamp"`
`44`	`43`	`};`
`45`	`44`	`}`
`46`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ public class QueryParameters`
`9`	`9`	`{`
`10`	`10`	`private static readonly string[] FieldsParams =`
`11`	`11`	`{`
`12`		`- "fields", "_source_include", "_source_exclude", "_source_includes", "_source_excludes",`
	`12`	`+ "fields", "_source_includes", "_source_excludes",`
`13`	`13`	`};`
`14`	`14`
`15`	`15`	`public bool Skip { get; set; }`