Replace MemoryStreamFactory usage with RecyclableMemoryStreamFactory (#4502) (#4519)

Usages of MemoryStreamFactory are replaced with RecyclableMemoryStreamFactory, MemoryStreamFactory is kept in place for external use.

Co-authored-by: Stuart Cam <stuart.cam@elastic.co>

Author: github-actions[bot]

src/Elasticsearch.Net/Providers/MemoryStreamFactory.cs

@@ -2,7 +2,6 @@
 
 namespace Elasticsearch.Net
 {
-	// TODO we use this in some places but its no longer clear to me why need to circumvent RecyclableMemoryStream in some cases
 	/// <summary>
 	/// A factory for creating memory streams using instances of <see cref="MemoryStream" />
 	/// </summary>

tests/Tests.Benchmarking/BulkBenchmarkTests.cs

@@ -25,7 +25,6 @@ public class BulkBenchmarkTests
 			new ElasticClient(new ConnectionSettings(new InMemoryConnection(Response, 200, null, null))
 				.DefaultIndex("index")
 				.EnableHttpCompression(false)
-				.MemoryStreamFactory(MemoryStreamFactory.Default)
 			);
 
 		private static readonly Nest7.IElasticClient ClientV7 =

tests/Tests/ClientConcepts/Connection/HttpConnectionTests.cs

@@ -84,7 +84,7 @@ private RequestData CreateRequestData(
 
 			var requestData = new RequestData(HttpMethod.POST, "/_search", "{ \"query\": { \"match_all\" : { } } }", connectionSettings,
 				new SearchRequestParameters(),
-				new MemoryStreamFactory()) { Node = node };
+				new RecyclableMemoryStreamFactory()) { Node = node };
 
 			return requestData;
 		}

tests/Tests/ClientConcepts/ConnectionPooling/BuildingBlocks/RequestPipelines.doc.cs

@@ -37,7 +37,7 @@ public void RequestPipeline()
 			var pipeline = new RequestPipeline(
 				settings,
 				DateTimeProvider.Default,
-				new MemoryStreamFactory(),
+				new RecyclableMemoryStreamFactory(),
 				new SearchRequestParameters());
 
 			pipeline.GetType().Should().Implement<IDisposable>();
@@ -49,7 +49,7 @@ public void RequestPipeline()
 			var requestPipeline = requestPipelineFactory.Create(
 				settings,
 				DateTimeProvider.Default, //<1> An <<date-time-providers,`IDateTimeProvider`>> implementation
-				new MemoryStreamFactory(),
+				new RecyclableMemoryStreamFactory(),
 				new SearchRequestParameters());
 
 			requestPipeline.Should().BeOfType<RequestPipeline>();
@@ -63,7 +63,7 @@ public void RequestPipeline()
 				settings,
 				requestPipelineFactory,
 				DateTimeProvider.Default,
-				new MemoryStreamFactory());
+				new RecyclableMemoryStreamFactory());
 
 			var client = new ElasticClient(transport);
 		}

tests/Tests/ClientConcepts/ConnectionPooling/Sniffing/RoleDetection.doc.cs

@@ -409,7 +409,7 @@ private RequestPipeline CreatePipeline()
 		{
 			var uri = TestConnectionSettings.CreateUri(this._cluster.Nodes.First().Port ?? 9200);
 			this._settings = new ConnectionSettings(new SniffingConnectionPool(new[] { uri }));
-			var pipeline = new RequestPipeline(this._settings, DateTimeProvider.Default, new MemoryStreamFactory(),
+			var pipeline = new RequestPipeline(this._settings, DateTimeProvider.Default, new RecyclableMemoryStreamFactory(),
 				new SearchRequestParameters());
 			return pipeline;
 		}

tests/Tests/CodeStandards/Serialization/GeoLocationTests.cs

@@ -16,7 +16,7 @@ public void CanDeserializeAndSerializeToWellKnownText()
 			var client = TestClient.DisabledStreaming;
 
 			Doc deserialized;
-			using (var stream = MemoryStreamFactory.Default.Create(Encoding.UTF8.GetBytes(wkt)))
+			using (var stream = RecyclableMemoryStreamFactory.Default.Create(Encoding.UTF8.GetBytes(wkt)))
 				deserialized = client.RequestResponseSerializer.Deserialize<Doc>(stream);
 
 			deserialized.Location.Should().Be(new GeoLocation(90, -90));